Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaultDate rather than defaultValue in FormsyDate #53

Merged
merged 2 commits into from
Apr 16, 2016

Conversation

bitdivision
Copy link
Contributor

Using defaultValue produces strange behaviour on date pickers.

The docs state that defaultDate should be used.
http://www.material-ui.com/#/components/date-picker

@bitdivision
Copy link
Contributor Author

Additionally, FormsyTime doesn't seem to implement any kind of defaultValue (or value?), was there a reason for this? It seems to work.

@mbrookes
Copy link
Collaborator

Using defaultValue produces strange behaviour on date pickers.

What behaviour? We won't know if it's fixed otherwise.

FormsyTime doesn't seem to implement any kind of defaultValue (or value?), was there a reason for this? It seems to work.

Props not consumed by ForsmyX are passed to the underlying Material-UI component.

@bitdivision
Copy link
Contributor Author

What behaviour? We won't know if it's fixed otherwise.

I can't reproduce the problem with FormsyDate right now. But I was having issues with the formatDate function not being run.

Props not consumed by ForsmyX are passed to the underlying Material-UI component.

On FormsyTime, Formsy validations don't work since the errorMessage prop is not passed, and you must pass defaultTime to get it to display anything on load which is different behaviour from the other FormsyX components I've used, which can be passed value

@mbrookes
Copy link
Collaborator

These changes look fine to me. @py-in-the-sky, any thoughts?

@mbrookes mbrookes merged commit 621f6cc into formsy:master Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants