Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up unit-testing tools #50

Merged
merged 1 commit into from
Feb 11, 2016
Merged

set up unit-testing tools #50

merged 1 commit into from
Feb 11, 2016

Conversation

py-in-the-sky
Copy link
Contributor

Also write a few unit tests to get things started.

@py-in-the-sky
Copy link
Contributor Author

@mbrookes If I got things set up right, you should be able to checkout this branch and run npm install && npm test without any errors. I just wanted to get some tools set up for testing. I figure we can fill out the test suite over time. The formsy-react repo has many great tests that we can model ours after.

@mbrookes
Copy link
Collaborator

mbrookes commented Feb 9, 2016

Thanks for this. 👍

I just upgraded babel. Could you rebase please?

@mbrookes
Copy link
Collaborator

mbrookes commented Feb 9, 2016

Also, some interesting discussion here. We're never going to have performance problems with this small set of components, but just for reference: mui/material-ui#3241 (comment)

Also write a few unit tests to get things started.
@py-in-the-sky
Copy link
Contributor Author

I rebased. The latest uses Karma, which both material-ui and formsy-react use. There are some things that just can't be tested outside an actual browser right now.

Regarding shallow rendering, I haven't looked into this enough to fully understand why, but tests involving formsy don't work without full rendering. The React docs provide only a short review of some limitations of shallow rendering.

mbrookes added a commit that referenced this pull request Feb 11, 2016
@mbrookes mbrookes merged commit 49b7650 into master Feb 11, 2016
@mbrookes
Copy link
Collaborator

Love it!

Thank you for getting this up and running!!!

@mbrookes mbrookes deleted the setup-testing-tools branch April 19, 2016 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants