Fixing some issues with AutoComplete #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for jumping in with a fix. It looks like with this component we still use this.state.value for passing the value to Formsy here. So we might need to add this.setValue, but I don't think we want to drop this.setState({ value }).
Tag v0.6.2 Update acknowledgements setMuiComponent_autoComplete setting value of auto complete Addresses two problems: - If using FormsyAutoComplete a user begins to type and uses the keyboard to select the first option in the AutoComplete menus (Keyboard, not mouse click) `handleBlur` will set `_value` before the selected autocomplete item text is set in the input. - If, for some reason, `blur` is not triggered on the AutoComplete element, an incorrect value can be set for the formsy element/model. Since there is little value of having a state attribute of `value` lets use the helper function (through the mixin) to guarantee that formsy has the most "up-to-date" value. Merge pull request #2 from alan-cruz2/patch-1 setMuiComponent_autoComplete Merge pull request #1 from alan-cruz2/using_setValue_autocomplete setting value of auto complete Update FormsyAutoComplete.jsx Update FormsyAutoComplete.jsx Merge pull request #3 from alan-cruz2/adding-back-setState Update FormsyAutoComplete.jsx
|
@rojobuffalo sorry it took so long. I squashed the commits into one, but it looks like I squashed one too many together. Sorry. let me know if this is a problem and I can fix it. |
|
Hi @alan-cruz2! I know it's been a few years, but this project is coming back to life! The first step is getting all the old PRs either closed or merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background issues:
If using FormsyAutoComplete a user begins to type and uses the keyboard to select the first option in the AutoComplete menus (Keyboard, not mouse click) handleBlur will set _value before the selected autocomplete item text is set in the input.
If, for some reason, blur is not triggered on the AutoComplete element, an incorrect value can be set for the formsy element/model.
Could not reset MUI AutoComplete component using
[AutoCompleteComponent].setState({ searchText: '' })because FormsyAutoComplete did not provide access to component.This PR:
setValueinstead ofsetState