Reduce calls to onChange of the parent form

[amannn]

I've noticed that when FormsyText is used in a controlled form where there's an onChange listener registered on the form, the listener is called three times currently.

I was able to reduce the calls to two so far, but I'm not sure where the other call is coming from.

I'm currently using a workaround like this:

onFormChange = (formData, didValueChange) => {
  if (!didValueChange) return;
  ...
}

But I'd say it's much cleaner if the callback is only called when there was actually a change.

[ryanblakeley]

This seems like a good idea.

[amannn]

Thanks for approving! But the test currently fails, as onChange is called twice. I'm not sure where the second call is coming from. Maybe there's something in formsy-react that triggers this and we can't fix it in formsy-material-ui. Do you have an idea?

If we can't find out, I could change the test to expect(calls.length).toBeLessThan(3); so the test works and we've at least got one call less.

[ryanblakeley]

1. Knocking off 1 of those calls is a marginal improvement. So the test you proposed works for me.
2. It very well could be that formsy is triggering the extra call. It looks like the place to test that hypothesis is probably in this Mixin.

[amannn]

I've updated the test assertion. If I find some more time I'll try to find the root cause in the mixin you linked. Thanks!