Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FormsyText internal _value to allow external setValue calls #174

Merged
merged 2 commits into from
Nov 24, 2016

Conversation

astonm
Copy link
Contributor

@astonm astonm commented Nov 22, 2016

Based on the example at christianalfoni/formsy-react#180

Fixes #161

@ryanblakeley ryanblakeley merged commit 89f4e26 into formsy:master Nov 24, 2016
@codeaholicguy
Copy link
Collaborator

codeaholicguy commented Feb 6, 2017

@rojobuffalo @astonm as this fix, we will face with problem that text field wont be updated immediately if prop updateImmediately is on in 0.5.4.

Because

    if (this.props.updateImmediately) {
       if (!this.changeValue) {
         this.changeValue = debounce(this.setValue, 400);
       }
       this.changeValue(event.currentTarget.value);
     }

I think we should control value instead of using getValue.

@mbrookes
Copy link
Collaborator

mbrookes commented Feb 7, 2017

TBH based on a cursory review, I'm not sure this PR should have been merged (buggy or not) as the parent component should be setting props, rather than using imperative methods.

@codeaholicguy
Copy link
Collaborator

@mbrookes related issue #191

ryanblakeley pushed a commit that referenced this pull request Feb 9, 2017
Revert #174 and re-apply interim changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants