Reduce calls to onChange of the parent form.

formsy · May 5, 2017 · 6b1f7c9 · 6b1f7c9
1 parent 8a1d9ec
commit 6b1f7c9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/FormsyText.jsx b/src/FormsyText.jsx
@@ -47,7 +47,7 @@ const FormsyText = React.createClass({
 
       if (isValueChanging || this.props.defaultValue === this.getValue()) {
         this.setState({ value, isValid });
-        this.setValue(value);
+        if (this.getValue() !== value) this.setValue(value);
       }
     }
   },

diff --git a/test/test.FormsyText.js b/test/test.FormsyText.js
@@ -234,6 +234,20 @@ describe('FormsyText', () => {
         formValues = formsyForm.getCurrentValues();
         expect(formValues.text).to.eq('some text');
       });
+
+      it('calls onChange once per text update', () => {
+        const calls = [];
+        const { parent, formsyTextWrapper } = makeTestParent({
+          onChange: (...args) => calls.push(args),
+          value: 'initial',
+        });
+
+        const inputDOM = formsyTextWrapper.find('input').node;
+        inputDOM.value = 'updated';
+        parent.setState({ value: 'updated' });
+
+        expect(calls.length).to.eq(1);
+      });
     });
 
     describe('resetting to', () => {