feat(otlp/metrics): add in memory exporter and noop meter provider #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyrag
force-pushed
the
feat/otlp-refine-metrics
branch
4 times, most recently
from
5cfbdd7
to
313b8d5
Compare
flemzord
approved these changes
Oct 14, 2024
gfyrag
force-pushed
the
feat/otlp-refine-metrics
branch
from
315cdf9
to
f397c44
Compare
gfyrag
commented
Oct 14, 2024
| @@ -10,9 +9,6 @@ import ( | |||
| func Execute(cmd *cobra.Command) { | |||
| BindEnvToCommand(cmd) | |||
| if err := cmd.Execute(); err != nil { | |||
| if _, err := fmt.Fprintln(os.Stderr, err); err != nil { | |||
There was a problem hiding this comment.
message display twice
gfyrag
force-pushed
the
feat/otlp-refine-metrics
branch
from
ef1b7fc
to
9410251
Compare
paul-nicolas
approved these changes
Oct 14, 2024
… noop tracer provider
gfyrag
force-pushed
the
feat/otlp-refine-metrics
branch
from
9410251
to
a81553f
Compare
Dav-14
reviewed
Oct 15, 2024
Comment on lines
+53
to
+56
| if cfg.Exporter == "" { | ||
| return fx.Provide(fx.Annotate(noop.NewTracerProvider, fx.As(new(trace.TracerProvider)))) | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.