Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add basic security #5

Merged
merged 21 commits into from
Sep 28, 2022
Merged

feat: Add basic security #5

merged 21 commits into from
Sep 28, 2022

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@08a0832). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 175d339 differs from pull request most recent head 00e285a. Consider uploading reports for the commit 00e285a to get more accurate results

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   47.43%           
=======================================
  Files           ?       37           
  Lines           ?     1598           
  Branches        ?        0           
=======================================
  Hits            ?      758           
  Misses          ?      739           
  Partials        ?      101

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gfyrag
gfyrag reviewed Sep 26, 2022
View reviewed changes
pkg/api/clients.go Outdated Show resolved Hide resolved
gfyrag
gfyrag reviewed Sep 26, 2022
View reviewed changes
pkg/api/scopes.go Outdated Show resolved Hide resolved
gfyrag
gfyrag reviewed Sep 26, 2022
View reviewed changes
pkg/api/users.go Outdated Show resolved Hide resolved
gfyrag
gfyrag reviewed Sep 26, 2022
View reviewed changes
test/server_test.go Outdated Show resolved Hide resolved
gfyrag
gfyrag approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why

gfyrag
gfyrag reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@gfyrag gfyrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment embedded

@antoinegelloz antoinegelloz marked this pull request as ready for review September 27, 2022 16:51
@antoinegelloz antoinegelloz merged commit 4beb421 into main Sep 28, 2022
@antoinegelloz antoinegelloz deleted the num-860-auth-server-basic-security branch September 28, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyrag gfyrag gfyrag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinegelloz @gfyrag