#14 make the test suite green

.circleci/config.yml

@@ -2,7 +2,10 @@ version: 2
 jobs:
   build:
     docker:
-      - image: circleci/node:lts-browsers
+      - image: circleci/node:8.10-browsers
+        environment:
+          JOBS: 2
+    parallelism: 1
     working_directory: ~/repo
     steps:
       - checkout

addon/components/printable-pages.js

@@ -4,6 +4,7 @@ import { inject as service } from "@ember/service";
 import { alias } from "@ember/object/computed";
 import { next } from "@ember/runloop";
 import { task } from "ember-concurrency";
+import { Promise } from "rsvp";
 
 export default Component.extend({
   layout,
@@ -28,19 +29,34 @@ export default Component.extend({
   // TASKS
   renderStartTask: task(function*(currentPage) {
     if (this.onRenderStart) {
-      next(() => this.onRenderStart(currentPage));
+      yield new Promise(resolve => {
+        next(() => {
+          this.onRenderStart(currentPage);
+          resolve();
+        });
+      });
     }
   }).keepLatest(),
 
   renderProgressTask: task(function*() {
     if (this.onRenderProgress) {
-      next(() => this.onRenderProgress(this.reportObject.lastPage));
+      yield new Promise(resolve => {
+        next(() => {
+          this.onRenderProgress(this.reportObject.lastPage);
+          resolve();
+        });
+      });
     }
   }).keepLatest(),
 
   reportIfCompleteTask: task(function*() {
     if (this.reportObject.isFinishedRendering && this.onRenderComplete) {
-      next(() => this.onRenderComplete(this.reportObject.lastPage));
+      yield new Promise(resolve => {
+        next(() => {
+          this.onRenderComplete(this.reportObject.lastPage);
+          resolve();
+        });
+      });
     }
   }).keepLatest(),
 

addon/components/printable-pages/section.js

@@ -1,7 +1,6 @@
 import Component from "@ember/component";
 import layout from "../../templates/components/printable-pages/section";
 import { getBy, array, sum, raw } from "ember-awesome-macros";
-import { alias } from "@ember/object/computed";
 import { htmlSafe } from "@ember/template";
 
 export default Component.extend({
@@ -18,7 +17,10 @@ export default Component.extend({
     this._super(...arguments);
     if (!this.shouldRender) return;
 
-    let id = this.register({data: this.data || [], columnCount: this.columnCount});
+    let id = this.register({
+      data: this.data || [],
+      columnCount: this.columnCount
+    });
     this.set("id", id);
   },
 

addon/services/document-data.js

@@ -1,7 +1,7 @@
 import Service from "@ember/service";
 import EmberObject, { computed } from "@ember/object";
 import { A } from "@ember/array";
-import { array, equal, raw, difference } from "ember-awesome-macros";
+import { array, equal, difference } from "ember-awesome-macros";
 import { alias } from "@ember/object/computed";
 import { run } from "@ember/runloop";
 

addon/templates/components/printable-pages.hbs

@@ -1,15 +1,15 @@
 {{yield (hash
-  title-page=(component 'printable-pages/title-page'
+  title-page=(component "printable-pages/title-page"
     pageLayout=this.pageLayout
     pageCount=this.reportObject.lastPage
   )
-  chapter=(component 'printable-pages/chapter'
+  chapter=(component "printable-pages/chapter"
     chapters=this.chapters
     lastReportPage=this.reportObject.lastPage
     pageLayout=this.pageLayout
-    register=(action 'registerChapter')
-    registerSection=(action 'registerSection' this.elementId)
-    addPage=(action 'addPage')
+    register=(action "registerChapter")
+    registerSection=(action "registerSection" this.elementId)
+    addPage=(action "addPage")
     checkIfComplete=(perform this.reportIfCompleteTask)
   )
 )}}

addon/templates/components/printable-pages/chapter-page.hbs

@@ -1,25 +1,27 @@
 {{yield (hash
-  block='header'
-  meta=@pageMeta
+  block="header"
+  meta=pageMeta
 )}}
 
-<div class='PrintablePages-pageBody js-page-body' style={{{this.bodyStyles}}}>
+{{! template-lint-disable no-inline-styles }}
+<div class="PrintablePages-pageBody js-page-body" style={{this.bodyStyles}}>
   {{yield (hash
-    block='body'
+    block="body"
     element=this.element
-    meta=@pageMeta
-    registerSection=(action 'registerSection')
-    onReadyForNextItem=(action 'onReadyForNextItem')
+    meta=pageMeta
+    registerSection=(action "registerSection")
+    onReadyForNextItem=(action "onReadyForNextItem")
   )
   }}
 
   {{! element used to check if the content has overflowed page body}}
-  <div class='js-visibility-tail' style="height: 1px;"></div>
+  <div class="js-visibility-tail" style="height: 1px;"></div>
 </div>
+{{! template-lint-enable no-inline-styles }}
 
 {{yield (hash
-  block='footer'
-  meta=@pageMeta
+  block="footer"
+  meta=pageMeta
 )}}
 
 <div class="js-page-break-after u-page-break-after"></div>

addon/templates/components/printable-pages/chapter.hbs

@@ -1,38 +1,38 @@
 {{#each this.pages as |page pageIndexInChapter|}}
-  {{#printable-pages/page-layout pageLayout=@pageLayout}}
+  {{#printable-pages/page-layout pageLayout=pageLayout}}
     {{#printable-pages/chapter-page
       pageIndexInChapter=pageIndexInChapter
       pageMeta=(hash
         current=(add this.startPage pageIndexInChapter)
         chapterNumber=(inc this.chapter.index)
-        total=@lastReportPage
+        total=lastReportPage
         isFirst=(eq page.number 1)
         isFirstInChapter=(eq page.number this.startPage)
-        isLast=(eq page.number @lastReportPage)
+        isLast=(eq page.number lastReportPage)
         isLastInChapter=(eq page.number this.endPage)
       )
 
       registerSection=(action this.registerSection this.elementId)
-      renderNextItem=(action 'renderNextItem' pageIndexInChapter)
-      onPageOverflow=(action 'onPageOverflow' pageIndexInChapter)
+      renderNextItem=(action "renderNextItem" pageIndexInChapter)
+      onPageOverflow=(action "onPageOverflow" pageIndexInChapter)
       as |pageComponent|
     }}
-      {{#if (eq pageComponent.block 'header')}}
+      {{#if (eq pageComponent.block "header")}}
         {{yield (hash
-          page-header=(component 'printable-pages/page-header' pageMeta=pageComponent.meta)
-          section=(component 'printable-pages/section' shouldRender=false)
-          page-footer=(component 'printable-pages/page-footer' shouldRender=false)
+          page-header=(component "printable-pages/page-header" pageMeta=pageComponent.meta)
+          section=(component "printable-pages/section" shouldRender=false)
+          page-footer=(component "printable-pages/page-footer" shouldRender=false)
         )}}
       {{/if}}
 
-      {{#if (eq pageComponent.block 'body')}}
+      {{#if (eq pageComponent.block "body")}}
         {{yield (hash
           number=pageComponent.meta
 
-          page-header=(component 'printable-pages/page-header' shouldRender=false)
-          page-footer=(component 'printable-pages/page-footer' shouldRender=false)
+          page-header=(component "printable-pages/page-header" shouldRender=false)
+          page-footer=(component "printable-pages/page-footer" shouldRender=false)
 
-          section=(component 'printable-pages/section'
+          section=(component "printable-pages/section"
             sectionMap=this.chapter.sectionMap
             pageIndexInChapter=pageIndexInChapter
             pageElement=pageComponent.element
@@ -43,11 +43,11 @@
         )}}
       {{/if}}
 
-      {{#if (eq pageComponent.block 'footer')}}
+      {{#if (eq pageComponent.block "footer")}}
         {{yield (hash
-          page-header=(component 'printable-pages/page-header' shouldRender=false)
-          section=(component 'printable-pages/section' shouldRender=false)
-          page-footer=(component 'printable-pages/page-footer' pageMeta=pageComponent.meta)
+          page-header=(component "printable-pages/page-header" shouldRender=false)
+          section=(component "printable-pages/section" shouldRender=false)
+          page-footer=(component "printable-pages/page-footer" pageMeta=pageComponent.meta)
         )}}
       {{/if}}
     {{/printable-pages/chapter-page}}

addon/templates/components/printable-pages/page-footer.hbs

@@ -1,5 +1,5 @@
 {{#if shouldRender}}
-  <div class='PrintablePages-pageFooter'>
-    {{yield (hash pageMeta=@pageMeta)}}
+  <div class="PrintablePages-pageFooter">
+    {{yield (hash pageMeta=pageMeta)}}
   </div>
 {{/if}}

addon/templates/components/printable-pages/page-header.hbs

@@ -1,5 +1,5 @@
 {{#if shouldRender}}
-  <div class='PrintablePages-pageHeader'>
-    {{yield (hash pageMeta=@pageMeta)}}
+  <div class="PrintablePages-pageHeader">
+    {{yield (hash pageMeta=pageMeta)}}
   </div>
 {{/if}}

addon/templates/components/printable-pages/page-layout.hbs

@@ -1,3 +1,5 @@
+{{! template-lint-disable no-inline-styles }}
 <section class="PrintablePages-page" style={{pageStyles}}>
   {{yield}}
 </section>
+{{! template-lint-enable no-inline-styles }}

addon/templates/components/printable-pages/section.hbs

@@ -1,5 +1,6 @@
 {{#if (and this.shouldRender this.page)}}
-  <div class='PrintablePages-section' style={{{this.style}}}>
+  {{! template-lint-disable no-inline-styles }}
+  <div class="PrintablePages-section" style={{this.style}}>
     {{#each this.items as |item index|}}
       {{#printable-pages/section-item section=this.section}}
         {{yield (hash
@@ -9,4 +10,5 @@
       {{/printable-pages/section-item}}
     {{/each}}
   </div>
+  {{! template-lint-enable no-inline-styles }}
 {{/if}}

addon/templates/components/printable-pages/title-page.hbs

@@ -1,8 +1,8 @@
-{{#printable-pages/page-layout pageLayout=@pageLayout}}
+{{#printable-pages/page-layout pageLayout=pageLayout}}
   <div class="PrintablePages-titlePage">
     {{yield (hash
       pageMeta=(hash
-        total=@pageCount
+        total=pageCount
       )
     )}}
   </div>

tests/dummy/app/controllers/demos/default.js

@@ -15,7 +15,7 @@ export default Controller.extend({
     updateProgress(currentPage) {
       this.set("currentPage", currentPage);
     },
-    complete(currentPage) {
+    complete() {
       this.set("renderTime", (new Date() - this.startTimeStamp) / 1000);
       this.set("isRunning", false);
       this.set("isComplete", true);

tests/dummy/app/templates/components/app-topbar.hbs

@@ -1,5 +1,5 @@
 {{#docs-header as |header|}}
-  {{#header.link 'demos'}}
+  {{#header.link "demos"}}
     Demos
   {{/header.link}}
 {{/docs-header}}

tests/dummy/app/templates/demos/default.hbs

@@ -8,9 +8,9 @@
 }}
 
 {{#printable-pages
-  onRenderStart=(action 'start')
-  onRenderProgress=(action 'updateProgress')
-  onRenderComplete=(action 'complete')
+  onRenderStart=(action "start")
+  onRenderProgress=(action "updateProgress")
+  onRenderComplete=(action "complete")
   as |document|
 }}
   {{#document.chapter as |chapter|}}

tests/dummy/app/templates/demos/page-layout.hbs

@@ -7,12 +7,12 @@
       {{#if (eq layout this.pageSize)}}
         <option selected value={{layout}}>{{layout}}</option>
       {{else}}
-         <option value={{layout}}>{{layout}}</option>
-       {{/if}}
+        <option value={{layout}}>{{layout}}</option>
+      {{/if}}
     {{/each}}
   </select>
   {{input type="text" value=this.marginSize}}
-  <input type='submit' value="Update" />
+  <input type="submit" value="Update">
 </form>
 
 {{#unless hidePages}}

tests/dummy/app/templates/demos/title-page.hbs

@@ -4,18 +4,18 @@
 
 {{#printable-pages as |document|}}
 
-  <!-- Document Title Page -->
+  {{! Document Title Page }}
   {{#document.title-page as |titlePage|}}
-    <div style="text-align:center;">As of March 2019</div>
+    <div>As of March 2019</div>
     <div class="TitlePage-hero">
       <h1>This is the document title page</h1>
     </div>
-    <div style="text-align:center;">
+    <div>
       ©2019 Forge 512, LLC | {{titlePage.pageMeta.total}}
     </div>
   {{/document.title-page}}
 
-  <!-- Chapters -->
+  {{! Chapters }}
   {{#document.chapter as |chapter|}}
     {{#chapter.page-header as |header|}}
       <div>

tests/dummy/app/templates/docs.hbs

@@ -2,8 +2,8 @@
 
 {{#docs-viewer as |viewer|}}
   {{#viewer.nav as |nav|}}
-    {{nav.item 'Introduction' 'docs.index'}}
-    {{nav.item 'Example' 'docs.example'}}
+    {{nav.item "Introduction" "docs.index"}}
+    {{nav.item "Example" "docs.example"}}
   {{/viewer.nav}}
 
   {{#viewer.main}}

tests/dummy/app/templates/index.hbs

@@ -1,13 +1,13 @@
 {{app-topbar}}
 
 {{docs-hero
-  logo='ember'
-  slimHeading='My'
-  strongHeading='Addon'
-  byline='My addon demo/marketing page.'}}
+  logo="ember"
+  slimHeading="My"
+  strongHeading="Addon"
+  byline="My addon demo/marketing page."}}
 
 {{#docs-demo as |demo|}}
-  {{#demo.example name='my-demo.hbs'}}
+  {{#demo.example name="my-demo.hbs"}}
     <p>Make sure to read up on the DocsDemo component before building out this page.</p>
   {{/demo.example}}
 {{/docs-demo}}

tests/dummy/app/templates/not-found.hbs

@@ -6,7 +6,7 @@
   {{#viewer.main}}
     <div class="docs-container">
       <h1>Not found</h1>
-      <p>This page doesn't exist. {{#link-to 'index'}}Head home?{{/link-to}}</p>
+      <p>This page doesn't exist. {{#link-to "index"}}Head home?{{/link-to}}</p>
     </div>
   {{/viewer.main}}
 {{/docs-viewer}}