Non reactive handling of running state #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Main doesn't seem to be building, so I had to branch off HEAD~1. Would it be possible to revert the latest commit and put it into a feature branch until it's building? |
17 tasks
…ication to the tick_args, so all changes get printed.
|
Also, sorry about all the formatting changes. I ran rust linter and cleared up the cargo warnings on files I touched. |
|
yeah, that is fare point. the last commit needs to be pushed to the feature branch |
|
Thanks for the awesome PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses many of the concerns raised by #65.
It does not attempt to solve any of the "halt" functionality, so reactive sequences and fallbacks are still going to play up a little.