Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to core 3 #42

Merged
merged 5 commits into from
May 6, 2022
Merged

fix: bump to core 3 #42

merged 5 commits into from
May 6, 2022

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

bumps to sfdx-core@3
removes unused files
fixes jsdocs
refactors a few unnecessary variables

What issues does this PR fix or reference?

@W-11092409@

@cristiand391
Copy link
Member

@WillieRuemmele do you want to release this as minor v3 or as telemetry v4? Make sure to manually bump the version if v4.

@cristiand391
Copy link
Member

cristiand391 commented May 5, 2022

QA notes:

Checkout salesforcecli/plugin-telemetry#282 and yarn link this PR:

✅ lib respects SFDX_DISABLE_INSIGHTS=true
❌ lib respects disableTelemetry=true setting
❌ when telemetry is disabled, ./bin/run telemetry | sfdx telemetry prints the ID as undefined

Screen Shot 2022-05-05 at 12 57 51

With telemetry enabled:

✅ lib respects SFDX_TELEMETRY_DEBUG and can run the uploader manually, also looked at the log and all the event props are properly populated:
Screen Shot 2022-05-05 at 13 07 47

✅ lib respects SFDX_TELEMETRY_PATH:
Screen Shot 2022-05-05 at 13 11 04

✅ lib respects SFDX_TELEMETRY_DISABLE_ACKNOWLEDGEMENT when the ack file doesn't exists (first run):
Screen Shot 2022-05-05 at 13 15 04

@cristiand391
Copy link
Member

QA notes:

With oclif/core PR linked

✅ plugin-telemetry respects disableTelemetry setting:
Screen Shot 2022-05-06 at 11 09 25

@cristiand391 cristiand391 merged commit 9ab8b09 into main May 6, 2022
@cristiand391 cristiand391 deleted the wr/parkingOrbit branch May 6, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants