Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify workflows to skip publish upon beta release #664

Merged
merged 2 commits into from
Aug 29, 2024
Merged

chore: modify workflows to skip publish upon beta release #664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3668823
chore: modify workflows to skip publish upon beta release
CristiCanizales Aug 27, 2024
08e4452
chore: modify condition
CristiCanizales Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/onRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,11 @@ jobs:
githubTag: ${{ github.event.release.tag_name || inputs.tag }}

secrets: inherit

publish-bundle:
if: ${{ success() && needs.getDistTag.outputs.tag != 'beta' }}
CristiCanizales marked this conversation as resolved.
Show resolved Hide resolved
uses: ./.github/workflows/releaseWithCoreBundle.yml
needs: [getDistTag, npm]
with:
branch: 'main'
secrets: inherit
17 changes: 9 additions & 8 deletions .github/workflows/releaseWithCoreBundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
name: publish source-tracking-bundle
on:
workflow_run:
workflows:
- publish
types:
- completed

workflow_call:
inputs:
branch:
description: 'Set the branch to use for release'
type: string
required: false
default: 'main'
workflow_dispatch:
inputs:
branch:
Expand All @@ -16,8 +17,8 @@ on:

jobs:
call-release-workflow:
if: ${{ inputs.branch || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')}}
if: ${{ inputs.branch }}
uses: forcedotcom/bundle-publish-scripts/.github/workflows/releaseWithCoreBundle.yml@main
secrets: inherit
with:
branch: ${{ inputs.branch || 'main'}}
branch: ${{ inputs.branch }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @iowillhoit
this value isn't used in a run block and seems safe, see:

https://github.com/forcedotcom/bundle-publish-scripts/blob/3e83ccd7faaa84316facb1c35ed0b2ebba073f06/.github/workflows/releaseWithCoreBundle.yml#L17