Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/remote-tracking-no-config-file #496

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Nov 1, 2023

What does this PR do?

Don't use ConfigFile
Preserve file format, but in-memory uses Map
Remove unused public methods (this module is NOT exported from STL so it's not a public API anyway, no breaking changes to be concerned about)

What issues does this PR fix or reference?

@W-14399468@

test/unit/remoteSourceTracking.test.ts Outdated Show resolved Hide resolved
test/unit/remoteSourceTracking.test.ts Outdated Show resolved Hide resolved
src/shared/remoteSourceTrackingService.ts Outdated Show resolved Hide resolved
src/shared/remoteSourceTrackingService.ts Show resolved Hide resolved
src/shared/remoteSourceTrackingService.ts Show resolved Hide resolved
@shetzel
Copy link
Collaborator

shetzel commented Nov 6, 2023

QA Notes (using dreamhouse-lwc project). All actions below were as expected so a global ✅

  1. create a scratch org and project deploy preview
  2. project retrieve preview
  3. project deploy start
  4. project deploy preview
  5. make remote change and project retrieve preview
  6. project retrieve start
  7. make local change and project deploy preview
  8. project deploy start
  9. make local and remote change to same metadata and project deploy preview and project retrieve preview
  10. project deploy start --ignore-conflicts
  11. project deploy preview and project retrieve preview

create a new project (sf project generate), auth to the scratch org used above, then
12. project retrieve preview
13. project retrieve start pulls all the source
14. project retrieve preview

@shetzel
Copy link
Collaborator

shetzel commented Nov 6, 2023

Also ran
project reset tracking and project delete tracking and both behaved as expected.

@shetzel shetzel merged commit 2ffdced into main Nov 6, 2023
27 checks passed
@shetzel shetzel deleted the sm/remote-tracking-no-config-file branch November 6, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants