fix: decode filepaths when comparing to the RSST for accurate results #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
commented
Jun 22, 2023
| @@ -196,7 +199,7 @@ export class RemoteSourceTrackingService extends ConfigFile<RemoteSourceTracking | |||
| // any item in an aura/LWC bundle needs to represent the top (bundle) level and the file itself | |||
| // so we de-dupe via a set | |||
| Array.from(new Set(elements.flatMap((element) => getMetadataKeyFromFileResponse(element)))).map((metadataKey) => { | |||
| const revision = revisions[metadataKey]; | |||
| const revision = revisions[decodeURI(metadataKey)]; | |||
There was a problem hiding this comment.
This is the real change, the other changes are just about ordering in the file after removing the eslint rule
mshanemc
approved these changes
Jun 22, 2023
| @@ -127,7 +124,13 @@ export class RemoteSourceTrackingService extends ConfigFile<RemoteSourceTracking | |||
| } | |||
| return path.isAbsolute(fileToDelete) ? fileToDelete : path.join(process.cwd(), fileToDelete); | |||
| } | |||
|
|
|||
| private static convertRevisionToChange(memberKey: string, memberRevision: MemberRevision): RemoteChangeElement { | |||
There was a problem hiding this comment.
looks like a function to me.
|
QA: used PDR. (had to remove Profiles from manual create profile named I'm going to merge all the other dependency PRs into this, and also modify the code to check for both encoded and non-encoded key matches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
allows filepaths to be URI decoded when comparing to what's in the RSST to prevent special characters from breaking source tracking
What issues does this PR fix or reference?
@W-13593791@
forcedotcom/cli#2212