Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/645 #664

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Pr/645 #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b23ec8c
fix: support jsforce 2.0
jayree Jun 6, 2022
ddf8151
Merge branch 'main' into support-jsforce2.0
shetzel Jul 12, 2022
6edd661
chore: auto-update metadata coverage in METADATA_SUPPORT.md
shetzel Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion METADATA_SUPPORT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ v56 introduces the following new types. Here's their current level of support

|Metadata Type|Support|Notes|
|:---|:---|:---|
|AIUsecaseDefinition|❌|Not supported, but support could be added (but not for tracking)|
|AIUsecaseDefinition|⚠️|Supports deploy/retrieve but not source tracking|
|AccountingFieldMapping|❌|Not supported, but support could be added|
|AccountingSettings|✅||
|BotBlock|❌|Not supported, but support could be added|
Expand All @@ -521,6 +521,9 @@ v56 introduces the following new types. Here's their current level of support
|DataSourceBundleDefinition|✅||
|DataSrcDataModelFieldMap|✅||
|DataStreamTemplate|✅||
|DigitalExperience|❌|Not supported, but support could be added (but not for tracking)|
|DigitalExperienceBundle|❌|Not supported, but support could be added (but not for tracking)|
|DigitalExperienceConfig|❌|Not supported, but support could be added (but not for tracking)|
|ExplainabilityMsgActionDefinition|❌|Not supported, but support could be added|
|ExpressionSetObjectAlias|❌|Not supported, but support could be added|
|FuelType|❌|Not supported, but support could be added|
Expand Down
2 changes: 1 addition & 1 deletion src/resolve/connectionResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class ConnectionResolver {
for await (const componentResult of componentPromises) {
for (const component of componentResult) {
let componentType: MetadataType;
if (typeof component.type === 'string') {
if (typeof component.type === 'string' && component.type.length) {
componentType = this.registry.getTypeByName(component.type);
} else {
// fix { type: { "$": { "xsi:nil": "true" } } }
Expand Down