fix: can retrive COFT with COT automatically #517
Conversation
| CustomObjectFieldTranslations are only addressable through their parent, and require a | ||
| CustomObjectTranslation file to be present | ||
| */ | ||
| if (childType.requiresParent && composedMetadata.length <= 2) { |
There was a problem hiding this comment.
this could use the isAddressable field, because COFT is the only metadata type to set either of those. It just seemed like the naming and intention could become confusing if I used isAddressable 🤷♂️
There was a problem hiding this comment.
I'm gonna defer to Steve's opinion on this one.
My question is whether it's valid to have isAddressable:false without requiresParent:true, or vice versa?
Or would you say that what we really meant was unaddressableWithoutParent ?
There was a problem hiding this comment.
I know there are more entities that are unaddressable, and that field is useful and makes sense so that one should remain. I agree with Shane that unaddressableWithoutParent is better. COT and COFT are unfortunate anomalies that hopefully will never happen again. unaddressableWithoutParent is the nicest description of this disastrous pair.
There was a problem hiding this comment.
I'd ship it as is if it fixed the problem. I'd like to see @shetzel opine on whether this should be a new property on MetadataType or not.
If it should be a new prop AND it's only valid in combination with isAddressable, then I'd want a validation to be added for that in registryValidation (verify that no childTypes exist with an invalid combination of those properties AND that they can only be used on childTypes).
| @@ -61,7 +62,7 @@ export class DecomposedMetadataTransformer extends BaseMetadataTransformer { | |||
| const childTypeId = type.children?.directories[tagKey]; | |||
| if (childTypeId) { | |||
| const childType = type.children.types[childTypeId]; | |||
| const tagValues = Array.isArray(tagValue) ? tagValue : [tagValue]; | |||
| const tagValues = normalizeToArray(tagValue); | |||
src/registry/types.ts
Outdated
| @@ -25,6 +25,7 @@ export interface MetadataRegistry { | |||
| * Metadata type definition in the registry. | |||
| */ | |||
| export interface MetadataType { | |||
| requiresParent?: boolean; | |||
There was a problem hiding this comment.
add the jsdoc for that the option does, like all the others (if we decide to use the new option). Otherwise, modify isAddressable's explanation
| CustomObjectFieldTranslations are only addressable through their parent, and require a | ||
| CustomObjectTranslation file to be present | ||
| */ | ||
| if (childType.requiresParent && composedMetadata.length <= 2) { |
There was a problem hiding this comment.
I'm gonna defer to Steve's opinion on this one.
My question is whether it's valid to have isAddressable:false without requiresParent:true, or vice versa?
Or would you say that what we really meant was unaddressableWithoutParent ?
What does this PR do?
fixes retrieval of COFT
What issues does this PR fix or reference?
forcedotcom/cli#1233, forcedotcom/cli#1241, forcedotcom/cli#1262, @W-10222972@
Functionality Before
retrieve -m CustomFieldTranslationwithout a CustomObjectTranslation in the org would only pull the CustomFieldTranslation files, which were invalid by themselves without a CustomObjectTranslation parent fileFunctionality After
a retrieve will retrieve both COFT/COT and write an empty COT if one doesn't exist in the org