Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate if parent exists, return path to be calculated #1431

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

we check if a parent exists based on it's calculated path, but then allow the rest of the conversion to calculate the path

What issues does this PR fix or reference?

#forcedotcom/cli#2977, @W-16383480@

Functionality Before

sf project retrieve start --package-name Test would create a Test/Test/main/default rather than Test/main/default for -object.meta.xml

Functionality After

calculates path, builds correct path later

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner September 30, 2024 20:23
@shetzel
Copy link
Contributor

shetzel commented Oct 4, 2024

QA
Output before fix:

| Created HelloWorldObject__c.HelloWorld_Compact_Layout CompactLayout  unlockedPackage/main/default/objects/HelloWorldObject__c/compactLayouts/HelloWorld_Compact_Layout.compactLayout-meta.xml
| Created HelloWorldObject__c.Account__c                CustomField    unlockedPackage/main/default/objects/HelloWorldObject__c/fields/Account__c.field-meta.xml
| Created HelloWorldObject__c.HelloWorldTextField__c    CustomField    unlockedPackage/main/default/objects/HelloWorldObject__c/fields/HelloWorldTextField__c.field-meta.xml
| Created HelloWorldObject__c                           CustomObject   unlockedPackage/unlockedPackage/main/default/objects/HelloWorldObject__c/HelloWorldObject__c.object-meta.xml

Output after fix:

| Created HelloWorldObject__c.HelloWorld_Compact_Layout CompactLayout  unlockedPackage/main/default/objects/HelloWorldObject__c/compactLayouts/HelloWorld_Compact_Layout.compactLayout-meta.xml
| Created HelloWorldObject__c.Account__c                CustomField    unlockedPackage/main/default/objects/HelloWorldObject__c/fields/Account__c.field-meta.xml
| Created HelloWorldObject__c.HelloWorldTextField__c    CustomField    unlockedPackage/main/default/objects/HelloWorldObject__c/fields/HelloWorldTextField__c.field-meta.xml
| Created HelloWorldObject__c                           CustomObject   unlockedPackage/main/default/objects/HelloWorldObject__c/HelloWorldObject__c.object-meta.xml

@shetzel shetzel merged commit 755f89c into main Oct 4, 2024
74 checks passed
@shetzel shetzel deleted the wr/packageRetrieveObjectMetaXml branch October 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants