feat: guarantee fileResponseSuccess has a path #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Jun 27, 2024
| @@ -548,13 +548,13 @@ describe('MetadataApiDeploy', () => { | |||
| fullName, | |||
| type: type.name, | |||
| state: ComponentStatus.Changed, | |||
| filePath: content, | |||
| filePath: ensureString(content), | |||
There was a problem hiding this comment.
there's a bunch of these in the test. The mocks come from SourceComponent, which has xml and content as optional properties.
the tests assert that they're there.
It's harder to work with the SourceComponent class (ex: to make SourceComponentWithXmlAndContent, etc) the way you would a simple object/type or to put a type guard around it
...
so it's probably simpler to do this ensure stuff for UT.
shetzel
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDR is the source of FileResponse (and its subtype FileResponseSuccess).
All the real code that produces them provide a filepath, but the type has it as
?.consumers with strict TS have to do checks for no reason.
fixes part of https://github.com/forcedotcom/eslint-config-salesforce-typescript/actions/runs/9703130477/job/26780562510?pr=246#step:9:9
so I guess it's related to @W-16116290@