Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): fewer adapters #1356

Closed
wants to merge 7 commits into from
Closed

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

while doing some background research for W-15771541 (unrelated) I noticed we've got a class (SourceAdapterFactory) that constructs classes (adapters) to answer a question where the answer is stored on the Adapter.

public allowMetadataWithContent(): boolean {
    return this.metadataWithContent;
  }

since type determines Adapter, why not use the type and not have to mess with the adapter.

metadataResolver constructs the factoy to construct adapters, and then might not even use it based on some other conditionals. Those now check first for early exit.

@mshanemc mshanemc requested a review from a team as a code owner June 25, 2024 17:01
@mshanemc
Copy link
Contributor Author

mshanemc commented Aug 1, 2024

closing in favor of #1382

@mshanemc mshanemc closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants