fix: remove xml cache #1347
Closed
fix: remove xml cache #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
reviewed
Jun 19, 2024
There was a problem hiding this comment.
the xml cache was specifically for CustomLabels. Create a project with 2000 CustomLabels and do a convert. You'll see the perf difference. With each individual custom label the entire CustomLabels file is re-read so performance, especially on windows, is pretty terrible without the cache.
the perf tests agreed with you 😄 . I wanted to see. Closed in favor of #1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
module-scope cache causes problems for long-lived IDE usage. this just removes it (goal is to compare the perf tests for EDA, which has a lot of decomposed stuff, to see if it matters at all)
What issues does this PR fix or reference?
@W-15952068@