fix: implicit dependency #1192
Merged
fix: implicit dependency #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
reviewed
Dec 14, 2023
| @@ -36,7 +36,8 @@ | |||
| "jszip": "^3.10.1", | |||
| "mime": "2.6.0", | |||
| "minimatch": "^5.1.6", | |||
| "proxy-agent": "^6.3.1" | |||
| "proxy-agent": "^6.3.1", | |||
| "ts-retry-promise": "^0.7.1" | |||
There was a problem hiding this comment.
Need lock file update as well
There was a problem hiding this comment.
nope, there was no change to it. That's the nature of these--they were working because they were already in the lockfile. [Until whatever was causing it to be in the lockfile changes.]
cristiand391
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
missing dep for ts-retry-promise
[skip-validate-pr]