Skip to content

Commit

Permalink
fix: increase conversion time expectation to 10 seconds
Browse files Browse the repository at this point in the history
  • Loading branch information
shetzel committed Jul 15, 2024
1 parent 327df18 commit dae87e3
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('Multiple large custom labels files', () => {
genUniqueDir: false,
});
// Longer than 2 seconds could indicate a regression
expect(Date.now() - convertStartTime, 'conversion should take less than 2 seconds').to.be.lessThan(2000);
expect(Date.now() - convertStartTime, 'conversion should take less than 10 seconds').to.be.lessThan(10000);

const convertedFiles = await getConvertedFilePaths(testOutput);
for (const file of convertedFiles) {
Expand Down

2 comments on commit dae87e3

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dae87e3 Previous: 327df18 Ratio
eda-componentSetCreate-linux 186 ms 183 ms 1.02
eda-sourceToMdapi-linux 2007 ms 2020 ms 0.99
eda-sourceToZip-linux 1841 ms 1815 ms 1.01
eda-mdapiToSource-linux 3007 ms 2959 ms 1.02
lotsOfClasses-componentSetCreate-linux 354 ms 368 ms 0.96
lotsOfClasses-sourceToMdapi-linux 3769 ms 3750 ms 1.01
lotsOfClasses-sourceToZip-linux 3150 ms 3129 ms 1.01
lotsOfClasses-mdapiToSource-linux 3595 ms 3519 ms 1.02
lotsOfClassesOneDir-componentSetCreate-linux 626 ms 636 ms 0.98
lotsOfClassesOneDir-sourceToMdapi-linux 6759 ms 6657 ms 1.02
lotsOfClassesOneDir-sourceToZip-linux 5685 ms 5851 ms 0.97
lotsOfClassesOneDir-mdapiToSource-linux 6394 ms 6435 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dae87e3 Previous: 327df18 Ratio
eda-componentSetCreate-win32 391 ms 407 ms 0.96
eda-sourceToMdapi-win32 3438 ms 3707 ms 0.93
eda-sourceToZip-win32 2652 ms 2880 ms 0.92
eda-mdapiToSource-win32 5609 ms 6134 ms 0.91
lotsOfClasses-componentSetCreate-win32 913 ms 972 ms 0.94
lotsOfClasses-sourceToMdapi-win32 7586 ms 8085 ms 0.94
lotsOfClasses-sourceToZip-win32 4739 ms 5219 ms 0.91
lotsOfClasses-mdapiToSource-win32 7589 ms 8134 ms 0.93
lotsOfClassesOneDir-componentSetCreate-win32 1497 ms 1485 ms 1.01
lotsOfClassesOneDir-sourceToMdapi-win32 13465 ms 13837 ms 0.97
lotsOfClassesOneDir-sourceToZip-win32 8891 ms 9203 ms 0.97
lotsOfClassesOneDir-mdapiToSource-win32 13659 ms 13520 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.