Skip to content

Commit

Permalink
chore: fixes from QA
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Aug 19, 2024
1 parent fbd77d3 commit dabbf72
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions contributing/metadata.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ The test is manually run, the file is committed to `patch`, and the output is ma

If your metadata type is simple and already in the file, run `yarn update-registry-org <MetadataEntity1> <MetadataEntity2>` (you'll see warnings if your type is missing or too complex for the script to handle)

Running the script with no params will try to do ALL missing metadata types.

### Path 2: Using Describe from an Org

> Note: The script asks your org for describe information about your type. Make sure that `sf org list metadata-types` returns the correct information for your type.
Expand Down
2 changes: 1 addition & 1 deletion scripts/update-registry/updateRegistryFromOrg.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const getMissingTypesAsDescribeResult = async (missingTypes: string[]): Promise<
])
);
// get the missingTypes from the describe
return missingTypes.map(([key]) => metadataObjectsByName.get(key)).filter(isDefined);
return missingTypes.map((key) => metadataObjectsByName.get(key)).filter(isDefined);
};

/** massage for slight differences between the 2 types */
Expand Down

2 comments on commit dabbf72

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dabbf72 Previous: fb50486 Ratio
eda-componentSetCreate-linux 233 ms 232 ms 1.00
eda-sourceToMdapi-linux 2371 ms 2406 ms 0.99
eda-sourceToZip-linux 1878 ms 1946 ms 0.97
eda-mdapiToSource-linux 2940 ms 2977 ms 0.99
lotsOfClasses-componentSetCreate-linux 435 ms 435 ms 1
lotsOfClasses-sourceToMdapi-linux 3705 ms 3804 ms 0.97
lotsOfClasses-sourceToZip-linux 3286 ms 3237 ms 1.02
lotsOfClasses-mdapiToSource-linux 3656 ms 3683 ms 0.99
lotsOfClassesOneDir-componentSetCreate-linux 758 ms 762 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-linux 6612 ms 6693 ms 0.99
lotsOfClassesOneDir-sourceToZip-linux 5827 ms 5871 ms 0.99
lotsOfClassesOneDir-mdapiToSource-linux 6564 ms 6732 ms 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dabbf72 Previous: fb50486 Ratio
eda-componentSetCreate-win32 606 ms 611 ms 0.99
eda-sourceToMdapi-win32 4276 ms 4169 ms 1.03
eda-sourceToZip-win32 2892 ms 2968 ms 0.97
eda-mdapiToSource-win32 5708 ms 5662 ms 1.01
lotsOfClasses-componentSetCreate-win32 1169 ms 1188 ms 0.98
lotsOfClasses-sourceToMdapi-win32 7659 ms 7663 ms 1.00
lotsOfClasses-sourceToZip-win32 5151 ms 4968 ms 1.04
lotsOfClasses-mdapiToSource-win32 7857 ms 7857 ms 1
lotsOfClassesOneDir-componentSetCreate-win32 2078 ms 2109 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-win32 13720 ms 13786 ms 1.00
lotsOfClassesOneDir-sourceToZip-win32 8976 ms 9187 ms 0.98
lotsOfClassesOneDir-mdapiToSource-win32 14020 ms 13928 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.