Skip to content

Commit

Permalink
chore: update comment for internal map initialization
Browse files Browse the repository at this point in the history
  • Loading branch information
shetzel committed Oct 12, 2023
1 parent ec7ec72 commit 8f9e7f5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/collections/decodeableMap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
export class DecodeableMap<K extends string, V> extends Map<string, V> {
// Internal map of decoded keys to encoded keys.
// E.g., { 'foo-v1.3 Layout': 'foo-v1%2E3 Layout' }
// This is initialized in the `keysMap` getter.
// This is initialized in the `keysMap` getter due to the constructor calling
// `super` before the initialization happens, and it needs to be initialized
// before `this.set()` is called or `TypeErrors` will be thrown.
private internalkeysMap!: Map<string, string>;

private get keysMap(): Map<string, string> {
Expand Down

2 comments on commit 8f9e7f5

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8f9e7f5 Previous: 67b41e6 Ratio
eda-componentSetCreate-linux 469 ms 388 ms 1.21
eda-sourceToMdapi-linux 11420 ms 8764 ms 1.30
eda-sourceToZip-linux 6786 ms 5772 ms 1.18
eda-mdapiToSource-linux 6541 ms 5055 ms 1.29
lotsOfClasses-componentSetCreate-linux 871 ms 598 ms 1.46
lotsOfClasses-sourceToMdapi-linux 10952 ms 12183 ms 0.90
lotsOfClasses-sourceToZip-linux 8693 ms 9412 ms 0.92
lotsOfClasses-mdapiToSource-linux 7190 ms 5657 ms 1.27
lotsOfClassesOneDir-componentSetCreate-linux 1406 ms 1028 ms 1.37
lotsOfClassesOneDir-sourceToMdapi-linux 16946 ms 15779 ms 1.07
lotsOfClassesOneDir-sourceToZip-linux 14641 ms 14375 ms 1.02
lotsOfClassesOneDir-mdapiToSource-linux 13476 ms 10349 ms 1.30

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8f9e7f5 Previous: 67b41e6 Ratio
eda-componentSetCreate-win32 505 ms 460 ms 1.10
eda-sourceToMdapi-win32 8843 ms 9088 ms 0.97
eda-sourceToZip-win32 6497 ms 6734 ms 0.96
eda-mdapiToSource-win32 7714 ms 7897 ms 0.98
lotsOfClasses-componentSetCreate-win32 1046 ms 960 ms 1.09
lotsOfClasses-sourceToMdapi-win32 14538 ms 14617 ms 0.99
lotsOfClasses-sourceToZip-win32 9776 ms 9455 ms 1.03
lotsOfClasses-mdapiToSource-win32 9245 ms 9511 ms 0.97
lotsOfClassesOneDir-componentSetCreate-win32 1844 ms 1696 ms 1.09
lotsOfClassesOneDir-sourceToMdapi-win32 22156 ms 22776 ms 0.97
lotsOfClassesOneDir-sourceToZip-win32 16164 ms 16405 ms 0.99
lotsOfClassesOneDir-mdapiToSource-win32 17077 ms 16930 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.