Skip to content

Commit

Permalink
fix: only emit variant telemetry when there are presets/variants
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Aug 13, 2024
1 parent aeca460 commit 641e458
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/registry/variants.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const logProjectVariants = (variants: ProjectVariants, projectDir: string): Proj
if (variants.presets?.length) {
logger.debug(`using sourceBehaviorOptions [${variants.presets.join(',')}] in ${projectDir}`);
}
if (variants?.presets ?? Object.keys(variants.registryCustomizations?.types ?? {}).length > 0) {
if (variants?.presets?.length ?? customizationTypes.length) {
void Lifecycle.getInstance().emitTelemetry({
library: 'SDR',
eventName: 'RegistryVariants',
Expand Down

2 comments on commit 641e458

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 641e458 Previous: 837c517 Ratio
eda-componentSetCreate-linux 232 ms 232 ms 1
eda-sourceToMdapi-linux 2257 ms 2314 ms 0.98
eda-sourceToZip-linux 1817 ms 1923 ms 0.94
eda-mdapiToSource-linux 2803 ms 2997 ms 0.94
lotsOfClasses-componentSetCreate-linux 493 ms 435 ms 1.13
lotsOfClasses-sourceToMdapi-linux 3682 ms 3736 ms 0.99
lotsOfClasses-sourceToZip-linux 3142 ms 3239 ms 0.97
lotsOfClasses-mdapiToSource-linux 3537 ms 3631 ms 0.97
lotsOfClassesOneDir-componentSetCreate-linux 739 ms 760 ms 0.97
lotsOfClassesOneDir-sourceToMdapi-linux 6343 ms 6647 ms 0.95
lotsOfClassesOneDir-sourceToZip-linux 5574 ms 5663 ms 0.98
lotsOfClassesOneDir-mdapiToSource-linux 6320 ms 6655 ms 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 641e458 Previous: 837c517 Ratio
eda-componentSetCreate-win32 695 ms 603 ms 1.15
eda-sourceToMdapi-win32 4748 ms 4274 ms 1.11
eda-sourceToZip-win32 3134 ms 2859 ms 1.10
eda-mdapiToSource-win32 6252 ms 5529 ms 1.13
lotsOfClasses-componentSetCreate-win32 1195 ms 1200 ms 1.00
lotsOfClasses-sourceToMdapi-win32 7828 ms 7531 ms 1.04
lotsOfClasses-sourceToZip-win32 5165 ms 5122 ms 1.01
lotsOfClasses-mdapiToSource-win32 8005 ms 7677 ms 1.04
lotsOfClassesOneDir-componentSetCreate-win32 2140 ms 2047 ms 1.05
lotsOfClassesOneDir-sourceToMdapi-win32 14204 ms 13500 ms 1.05
lotsOfClassesOneDir-sourceToZip-win32 9216 ms 8961 ms 1.03
lotsOfClassesOneDir-mdapiToSource-win32 14474 ms 13802 ms 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.