Skip to content

Commit

Permalink
fix: error for using -m CustomLabels with the preset
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Aug 9, 2024
1 parent 49ee212 commit 6046634
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/collections/componentSetBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ export const entryToTypeAndName =
if (type.isAddressable === false && parent !== undefined && !type.unaddressableWithoutParent) {
throw new Error(`Cannot use this type, instead use ${parent.name}`);
}
if (type.name === 'CustomLabels' && type.strategies?.transformer === 'decomposedLabels') {
throw new Error('Use CustomLabel instead of CustomLabels for decomposed labels');
}
return { type, metadataName: name.length ? name.join(':').trim() : '*' };
};

Expand Down

2 comments on commit 6046634

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 6046634 Previous: 49ee212 Ratio
eda-componentSetCreate-linux 227 ms 232 ms 0.98
eda-sourceToMdapi-linux 2283 ms 2216 ms 1.03
eda-sourceToZip-linux 1909 ms 1900 ms 1.00
eda-mdapiToSource-linux 2905 ms 2837 ms 1.02
lotsOfClasses-componentSetCreate-linux 427 ms 433 ms 0.99
lotsOfClasses-sourceToMdapi-linux 3740 ms 3677 ms 1.02
lotsOfClasses-sourceToZip-linux 3302 ms 3038 ms 1.09
lotsOfClasses-mdapiToSource-linux 3698 ms 3518 ms 1.05
lotsOfClassesOneDir-componentSetCreate-linux 765 ms 741 ms 1.03
lotsOfClassesOneDir-sourceToMdapi-linux 6536 ms 6382 ms 1.02
lotsOfClassesOneDir-sourceToZip-linux 5879 ms 5628 ms 1.04
lotsOfClassesOneDir-mdapiToSource-linux 6649 ms 6404 ms 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 6046634 Previous: 49ee212 Ratio
eda-componentSetCreate-win32 697 ms 723 ms 0.96
eda-sourceToMdapi-win32 4763 ms 4400 ms 1.08
eda-sourceToZip-win32 3197 ms 3451 ms 0.93
eda-mdapiToSource-win32 6277 ms 6537 ms 0.96
lotsOfClasses-componentSetCreate-win32 1297 ms 1368 ms 0.95
lotsOfClasses-sourceToMdapi-win32 8432 ms 8637 ms 0.98
lotsOfClasses-sourceToZip-win32 5428 ms 5721 ms 0.95
lotsOfClasses-mdapiToSource-win32 8530 ms 8712 ms 0.98
lotsOfClassesOneDir-componentSetCreate-win32 2067 ms 2368 ms 0.87
lotsOfClassesOneDir-sourceToMdapi-win32 13841 ms 15471 ms 0.89
lotsOfClassesOneDir-sourceToZip-win32 9131 ms 10593 ms 0.86
lotsOfClassesOneDir-mdapiToSource-win32 14055 ms 16127 ms 0.87

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.