Skip to content

Commit

Permalink
fix: better conditional
Browse files Browse the repository at this point in the history
  • Loading branch information
@shetzel
shetzel committed Jul 15, 2024
1 parent 2aa9cd5 commit 56814c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/convert/convertContext/recompositionFinalizer.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const recompose =
// all the children. This checks for multiple parent components and gets the xml
// file content from each.
if (
childComponents &&
childComponents.length &&
stateValue.component.type.strategies?.recomposition === 'startEmpty' &&
stateValue.component.type.strategies?.transformer === 'nonDecomposed'
) {
Expand Down

2 comments on commit 56814c1

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56814c1 Previous: 2aa9cd5 Ratio
eda-componentSetCreate-linux 184 ms 197 ms 0.93
eda-sourceToMdapi-linux 2306 ms 2256 ms 1.02
eda-sourceToZip-linux 1767 ms 1838 ms 0.96
eda-mdapiToSource-linux 2888 ms 2843 ms 1.02
lotsOfClasses-componentSetCreate-linux 343 ms 357 ms 0.96
lotsOfClasses-sourceToMdapi-linux 3732 ms 3651 ms 1.02
lotsOfClasses-sourceToZip-linux 3054 ms 3155 ms 0.97
lotsOfClasses-mdapiToSource-linux 3532 ms 3497 ms 1.01
lotsOfClassesOneDir-componentSetCreate-linux 633 ms 615 ms 1.03
lotsOfClassesOneDir-sourceToMdapi-linux 6504 ms 6490 ms 1.00
lotsOfClassesOneDir-sourceToZip-linux 5663 ms 5741 ms 0.99
lotsOfClassesOneDir-mdapiToSource-linux 6327 ms 6314 ms 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56814c1 Previous: 2aa9cd5 Ratio
eda-componentSetCreate-win32 489 ms 364 ms 1.34
eda-sourceToMdapi-win32 5041 ms 3940 ms 1.28
eda-sourceToZip-win32 3395 ms 2624 ms 1.29
eda-mdapiToSource-win32 6959 ms 5384 ms 1.29
lotsOfClasses-componentSetCreate-win32 1042 ms 844 ms 1.23
lotsOfClasses-sourceToMdapi-win32 9154 ms 7425 ms 1.23
lotsOfClasses-sourceToZip-win32 5801 ms 4779 ms 1.21
lotsOfClasses-mdapiToSource-win32 9404 ms 7444 ms 1.26
lotsOfClassesOneDir-componentSetCreate-win32 1826 ms 1457 ms 1.25
lotsOfClassesOneDir-sourceToMdapi-win32 16272 ms 13021 ms 1.25
lotsOfClassesOneDir-sourceToZip-win32 9961 ms 8422 ms 1.18
lotsOfClassesOneDir-mdapiToSource-win32 14944 ms 13298 ms 1.12

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.