Skip to content

Commit

Permalink
fix: add EmailTemplateFolder
Browse files Browse the repository at this point in the history
  • Loading branch information
@shetzel
shetzel committed Sep 3, 2024
1 parent 558bd8a commit 44b539e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/collections/componentSet.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ const constructFullName = (registry: RegistryAccess, type: MetadataType, fullNam
// Some InFolder types are different. e.g., Report/ReportFolder & Dashboard/DashboardFolder.
// ReportFolders are deployed/retrieved as Reports. If a ReportFolder is being added append
// a "/" so the metadata API can identify it as a folder.
['DashboardFolder', 'ReportFolder'].includes(type.name) && !fullName.endsWith('/')
['DashboardFolder', 'ReportFolder', 'EmailTemplateFolder'].includes(type.name) && !fullName.endsWith('/')
? `${fullName}/`
: registry.getParentType(type.name)?.strategies?.recomposition === 'startEmpty' && fullName.includes('.')
? // they're reassembled like CustomLabels.MyLabel
Expand Down

2 comments on commit 44b539e

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 44b539e Previous: 558bd8a Ratio
eda-componentSetCreate-linux 241 ms 236 ms 1.02
eda-sourceToMdapi-linux 2298 ms 2353 ms 0.98
eda-sourceToZip-linux 1860 ms 1867 ms 1.00
eda-mdapiToSource-linux 2924 ms 2859 ms 1.02
lotsOfClasses-componentSetCreate-linux 435 ms 428 ms 1.02
lotsOfClasses-sourceToMdapi-linux 3743 ms 3730 ms 1.00
lotsOfClasses-sourceToZip-linux 3260 ms 3069 ms 1.06
lotsOfClasses-mdapiToSource-linux 3658 ms 3629 ms 1.01
lotsOfClassesOneDir-componentSetCreate-linux 759 ms 737 ms 1.03
lotsOfClassesOneDir-sourceToMdapi-linux 6608 ms 6468 ms 1.02
lotsOfClassesOneDir-sourceToZip-linux 5907 ms 5658 ms 1.04
lotsOfClassesOneDir-mdapiToSource-linux 6627 ms 6405 ms 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 44b539e Previous: 558bd8a Ratio
eda-componentSetCreate-win32 702 ms 644 ms 1.09
eda-sourceToMdapi-win32 4541 ms 4148 ms 1.09
eda-sourceToZip-win32 3207 ms 2902 ms 1.11
eda-mdapiToSource-win32 6210 ms 5595 ms 1.11
lotsOfClasses-componentSetCreate-win32 1337 ms 1213 ms 1.10
lotsOfClasses-sourceToMdapi-win32 8383 ms 7651 ms 1.10
lotsOfClasses-sourceToZip-win32 5450 ms 4944 ms 1.10
lotsOfClasses-mdapiToSource-win32 8702 ms 7921 ms 1.10
lotsOfClassesOneDir-componentSetCreate-win32 2147 ms 2119 ms 1.01
lotsOfClassesOneDir-sourceToMdapi-win32 13993 ms 13815 ms 1.01
lotsOfClassesOneDir-sourceToZip-win32 9307 ms 9269 ms 1.00
lotsOfClassesOneDir-mdapiToSource-win32 14439 ms 14134 ms 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.