Skip to content

Commit

Permalink
fix: add the ExpressionSetObjectAlias metadata type
Browse files Browse the repository at this point in the history
  • Loading branch information
shetzel committed Jan 9, 2024
1 parent 27e615a commit 34ef784
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 8 additions & 0 deletions src/registry/metadataRegistry.json
Original file line number Diff line number Diff line change
Expand Up @@ -2572,6 +2572,13 @@
}
}
},
"expressionsetobjectalias": {
"id": "expressionsetobjectalias",
"name": "ExpressionSetObjectAlias",
"suffix": "expressionSetObjectAlias",
"directoryName": "expressionSetObjectAlias",
"strictDirectoryName": false
},
"briefcasedefinition": {
"id": "briefcasedefinition",
"name": "BriefcaseDefinition",
Expand Down Expand Up @@ -3739,6 +3746,7 @@
"decisionMatrixDefinitionVersion": "decisionmatrixdefinitionversion",
"expressionSetDefinition": "expressionsetdefinition",
"expressionSetDefinitionVersion": "expressionsetdefinitionversion",
"expressionSetObjectAlias": "expressionsetobjectalias",
"briefcaseDefinition": "briefcasedefinition",
"batchProcessJobDefinition": "batchprocessjobdefinition",
"acctMgrTargetSetting": "acctmgrtargetsettings",
Expand Down
3 changes: 0 additions & 3 deletions src/registry/nonSupportedTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ export const metadataTypes = [
'ReferencedDashboard',
'WaveAnalyticAssetCollection',

// spins up fine with feature B2CLOYALTYMANAGEMENT, not in describe
'ExpressionSetObjectAlias',

// requires no features, but not in describe
'ExternalDataSrcDescriptor',

Expand Down

2 comments on commit 34ef784

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 34ef784 Previous: b68c3fc Ratio
eda-componentSetCreate-linux 222 ms 202 ms 1.10
eda-sourceToMdapi-linux 1968 ms 1953 ms 1.01
eda-sourceToZip-linux 1685 ms 1703 ms 0.99
eda-mdapiToSource-linux 3037 ms 2988 ms 1.02
lotsOfClasses-componentSetCreate-linux 405 ms 427 ms 0.95
lotsOfClasses-sourceToMdapi-linux 3505 ms 3426 ms 1.02
lotsOfClasses-sourceToZip-linux 2752 ms 2667 ms 1.03
lotsOfClasses-mdapiToSource-linux 3423 ms 3355 ms 1.02
lotsOfClassesOneDir-componentSetCreate-linux 660 ms 640 ms 1.03
lotsOfClassesOneDir-sourceToMdapi-linux 6352 ms 6196 ms 1.03
lotsOfClassesOneDir-sourceToZip-linux 5184 ms 4967 ms 1.04
lotsOfClassesOneDir-mdapiToSource-linux 6139 ms 6147 ms 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 34ef784 Previous: b68c3fc Ratio
eda-componentSetCreate-win32 412 ms 405 ms 1.02
eda-sourceToMdapi-win32 3485 ms 3530 ms 0.99
eda-sourceToZip-win32 2659 ms 2650 ms 1.00
eda-mdapiToSource-win32 5840 ms 5839 ms 1.00
lotsOfClasses-componentSetCreate-win32 928 ms 881 ms 1.05
lotsOfClasses-sourceToMdapi-win32 7499 ms 7712 ms 0.97
lotsOfClasses-sourceToZip-win32 4683 ms 4832 ms 0.97
lotsOfClasses-mdapiToSource-win32 7402 ms 7521 ms 0.98
lotsOfClassesOneDir-componentSetCreate-win32 1475 ms 1490 ms 0.99
lotsOfClassesOneDir-sourceToMdapi-win32 13637 ms 13970 ms 0.98
lotsOfClassesOneDir-sourceToZip-win32 8493 ms 8651 ms 0.98
lotsOfClassesOneDir-mdapiToSource-win32 13413 ms 13784 ms 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.