Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @jsforce/jsforce-node from 3.1.0 to 3.2.0 #1062

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 27, 2024

Bumps @jsforce/jsforce-node from 3.1.0 to 3.2.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@jsforce/jsforce-node](https://github.com/jsforce/jsforce) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/jsforce/jsforce/releases)
- [Changelog](https://github.com/jsforce/jsforce/blob/master/CHANGELOG.md)
- [Commits](jsforce/jsforce@3.1.0...3.2.0)

---
updated-dependencies:
- dependency-name: "@jsforce/jsforce-node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 27, 2024
@cristiand391
Copy link
Member

I think the timeoutFactor option added in jsforce v3.2 is breaking UTs, looking at it now.

`AuthInfo.determineIfDevHub` and `AuthInfo.getNamespacePrefix` do some
requests when creating a new AuthInfo instance, if we don't stub these
methods the requests are done and jsforce keeps retrying requests until
mocha times out.
@@ -245,6 +245,9 @@ describe('AuthInfo', () => {
});

it('should return an AuthInfo instance when passed a parent username', async () => {
stubMethod($$.SANDBOX, AuthInfo.prototype, 'determineIfDevHub').resolves(false);
stubMethod($$.SANDBOX, AuthInfo.prototype, 'getNamespacePrefix').resolves();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you checkout the commit before mine (0f0d32fde65f893ff9fddd1169c8de750b575d51) and run JSFORCE_LOG_LEVEL=DEBUG yarn mocha test/unit/org/authInfoTest.ts

you'll see this:

➜  sfdx-core git:(dependabot-npm_and_yarn-jsforce-jsforce-node-3.2.0) ✗ JSFORCE_LOG_L
EVEL=DEBUG yarn mocha test/unit/org/authInfoTest.ts
yarn run v1.22.19
$ /Users/cdominguez/code/gh/sf/sfdx-core/node_modules/.bin/mocha test/unit/org/authIn
foTest.ts


  AuthInfo
    create
DEBUG   [fetch]  Request failed
DEBUG   [fetch]  retrying for the 1 time
DEBUG   [fetch]  Error: FetchError: request to https://instance.84edc3d01c22bbd5da27a
e8a686e2a52.salesforce.com//services/data/v51.0/query?q=SELECT%20Id%20FROM%20ScratchO
rgInfo%20limit%201 failed, reason: getaddrinfo ENOTFOUND instance.84edc3d01c22bbd5da2
7ae8a686e2a52.salesforce.com
DEBUG   [fetch]  Request failed
DEBUG   [fetch]  retrying for the 2 time
DEBUG   [fetch]  Error: FetchError: request to https://instance.84edc3d01c22bbd5da27a
e8a686e2a52.salesforce.com//services/data/v51.0/query?q=SELECT%20Id%20FROM%20ScratchO
rgInfo%20limit%201 failed, reason: getaddrinfo ENOTFOUND instance.84edc3d01c22bbd5da2
7ae8a686e2a52.salesforce.com
DEBUG   [fetch]  Request failed
DEBUG   [fetch]  retrying for the 3 time
DEBUG   [fetch]  Error: FetchError: request to https://instance.84edc3d01c22bbd5da27a
e8a686e2a52.salesforce.com//services/data/v51.0/query?q=SELECT%20Id%20FROM%20ScratchO
rgInfo%20limit%201 failed, reason: getaddrinfo ENOTFOUND instance.84edc3d01c22bbd5da2
7ae8a686e2a52.salesforce.com

jsforce v3.1 retried these failures very fast, v3.2 delays each retry incrementally so mocha just timed out.

@mshanemc mshanemc merged commit cfba51b into main Apr 30, 2024
66 checks passed
@mshanemc mshanemc deleted the dependabot-npm_and_yarn-jsforce-jsforce-node-3.2.0 branch April 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants