Skip to content

Commit

Permalink
chore: revert changes in esbuild publish
Browse files Browse the repository at this point in the history
  • Loading branch information
@CristiCanizales
CristiCanizales committed Jun 3, 2024
1 parent 91e7e08 commit e22ce3e
Showing 1 changed file with 22 additions and 10 deletions.
32 changes: 22 additions & 10 deletions .github/workflows/esbuild-publish.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,32 @@ on:
required: false

jobs:
bundle:
if: ${{ inputs.branch || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')}}
uses: ./.github/workflows/bundle.yml
secrets: inherit
with:
branch: ${{ inputs.branch || 'main' }}
nodeVersion: ${{ inputs.nodeVersion || 'lts/*'}}
publish:
needs: bundle
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ inputs.branch || 'main' }}
ref: ${{ inputs.branch }}
- uses: actions/setup-node@v4
with:
node-version: ${{ inputs.nodeVersion }}
registry-url: 'https://registry.npmjs.org'
cache: yarn
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
- name: Install esbuild Dependencies
run: |
yarn add -D esbuild@^0.19.5 esbuild-plugin-pino@^2.1.0 npm-dts@^1.3.12 esbuild-plugin-tsc@^0.4.0
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
- name: Update for Bundling
run: |
node scripts/updateForBundling.js
- name: Generate Bundle
run: |
yarn build
node scripts/build.js
- name: Post Bundling Update
run: |
node scripts/postBundlingUpdate.js
- name: Publish a Package
run: |
npm config set //registry.npmjs.org/:_authToken=$NODE_AUTH_TOKEN
Expand Down

4 comments on commit e22ce3e

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: e22ce3e Previous: 91e7e08 Ratio
Child logger creation 477360 ops/sec (±1.41%) 485523 ops/sec (±0.45%) 1.02
Logging a string on root logger 832701 ops/sec (±7.07%) 838636 ops/sec (±6.33%) 1.01
Logging an object on root logger 614718 ops/sec (±8.96%) 618781 ops/sec (±7.53%) 1.01
Logging an object with a message on root logger 4329 ops/sec (±217.48%) 27610 ops/sec (±182.83%) 6.38
Logging an object with a redacted prop on root logger 442180 ops/sec (±13.29%) 524004 ops/sec (±8.30%) 1.19
Logging a nested 3-level object on root logger 385824 ops/sec (±6.22%) 17884 ops/sec (±187.00%) 0.046352741146222114

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e22ce3e Previous: 91e7e08 Ratio
Logging an object with a message on root logger 4329 ops/sec (±217.48%) 27610 ops/sec (±182.83%) 6.38

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: e22ce3e Previous: 91e7e08 Ratio
Child logger creation 314579 ops/sec (±1.11%) 317217 ops/sec (±0.88%) 1.01
Logging a string on root logger 828052 ops/sec (±6.29%) 733299 ops/sec (±7.32%) 0.89
Logging an object on root logger 553434 ops/sec (±11.17%) 570130 ops/sec (±6.18%) 1.03
Logging an object with a message on root logger 3230 ops/sec (±215.95%) 6712 ops/sec (±202.76%) 2.08
Logging an object with a redacted prop on root logger 439000 ops/sec (±13.12%) 449629 ops/sec (±8.87%) 1.02
Logging a nested 3-level object on root logger 322510 ops/sec (±4.82%) 331794 ops/sec (±5.11%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e22ce3e Previous: 91e7e08 Ratio
Logging an object with a message on root logger 3230 ops/sec (±215.95%) 6712 ops/sec (±202.76%) 2.08

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.