fix: fixed maxQueryLimit validation

forcedotcom · Jan 20, 2021 · 6431065 · 6431065
1 parent c294db6
commit 6431065
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/src/config/config.ts b/src/config/config.ts
@@ -6,7 +6,7 @@
  */
 
 import { keyBy, set } from '@salesforce/kit';
-import { Dictionary, ensure, isNumber, isString } from '@salesforce/ts-types';
+import { Dictionary, ensure, isString } from '@salesforce/ts-types';
 import { Logger } from '../logger';
 import { Crypto } from '../crypto';
 import { Messages } from '../messages';
@@ -181,7 +181,7 @@ export class Config extends ConfigFile<ConfigFile.Options> {
     {
       key: Config.MAX_QUERY_LIMIT,
       input: {
-        validator: (value) => isNumber(value),
+        validator: (value) => !isNaN(Number(value)),
         get failedMessage() {
           return Config.messages?.getMessage('InvalidNumberConfigValue');
         },

diff --git a/test/unit/config/configTest.ts b/test/unit/config/configTest.ts
@@ -146,6 +146,36 @@ describe('Config', () => {
           expect(err).to.have.property('name', 'InvalidConfigValue');
         }
       });
+      describe('maxQueryLimit', () => {
+        it('will throw an error', async () => {
+          const config: Config = await Config.create(Config.getDefaultOptions(true));
+          try {
+            config.set('maxQueryLimit', '123abc');
+            assert.fail('Expected an error to be thrown.');
+          } catch (err) {
+            expect(err).to.have.property('name', 'InvalidConfigValue');
+          }
+        });
+        it('will throw an error', async () => {
+          const config: Config = await Config.create(Config.getDefaultOptions(true));
+          try {
+            config.set('maxQueryLimit', 'abc');
+            assert.fail('Expected an error to be thrown.');
+          } catch (err) {
+            expect(err).to.have.property('name', 'InvalidConfigValue');
+          }
+        });
+        it('will set config value', async () => {
+          const config: Config = await Config.create(Config.getDefaultOptions(true));
+          const res = config.set('maxQueryLimit', '123');
+          expect(res.maxQueryLimit).to.equal('123');
+        });
+        it('will set config value', async () => {
+          const config: Config = await Config.create(Config.getDefaultOptions(true));
+          const res = config.set('maxQueryLimit', 123);
+          expect(res.maxQueryLimit).to.equal(123);
+        });
+      });
     });
 
     it('PropertyInput validation', async () => {