Merge pull request #1122 from forcedotcom/sm/test-naming

Sm/test-naming
forcedotcom · Aug 7, 2024 · 4bf9406 · 4bf9406 · svc-cli-bot · Aug 7, 2024
2 parents 659e490 + 00155a3
commit 4bf9406
Show file tree

Hide file tree

Showing 59 changed files with 14 additions and 20 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -44,6 +44,8 @@ jobs:
       command: 'yarn test:nuts'
       os: ${{ matrix.os }}
       useCache: false
+      # remove the test folder for sfdx-core
+      preBuildCommands: 'shx rm -rf test'
       preSwapCommands: 'yarn upgrade @jsforce/jsforce-node@latest; npx yarn-deduplicate; yarn install'
       preExternalBuildCommands: 'shx rm -rf node_modules/@salesforce/core/node_modules/@jsforce/jsforce-node shx rm -rf node_modules/@salesforce/sf-plugins-core/node_modules/@salesforce/core node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/core node_modules/@salesforce/source-tracking/node_modules/@salesforce/core node_modules/@salesforce/source-deploy-retrieve/node_modules/@salesforce/core node_modules/@salesforce/apex-node/node_modules/@salesforce/core'
     secrets: inherit

diff --git a/.mocharc.json b/.mocharc.json
@@ -1,5 +1,5 @@
 {
-  "require": "test/init.js, ts-node/register, source-map-support/register",
+  "require": "ts-node/register, source-map-support/register",
   "watch-extensions": "ts",
   "watch-files": ["src", "test"],
   "recursive": true,

diff --git a/.sfdevrc.json b/.sfdevrc.json
@@ -1,6 +1,6 @@
 {
   "test": {
-    "testsPath": "test/**/*Test.ts"
+    "testsPath": "test/unit/**/*.test.ts"
   },
   "wireit": {
     "compile": {

diff --git a/package.json b/package.json
@@ -147,7 +147,7 @@
       "output": []
     },
     "test:only": {
-      "command": "nyc mocha \"test/**/*Test.ts\"",
+      "command": "nyc mocha \"test/unit/**/*.test.ts\"",
       "env": {
         "FORCE_COLOR": "2"
       },
@@ -182,4 +182,4 @@
       "command": "tsc -p typedocExamples"
     }
   }
-}
+}
diff --git a/test/init.js b/test/init.js
diff --git a/test/tsconfig.json b/test/tsconfig.json
@@ -1,6 +1,6 @@
 {
   "extends": "@salesforce/dev-config/tsconfig-test-strict",
-  "include": ["nut/**/*.ts", "unit/**/*.ts", "perf/**/*.ts", "nut/configFileConcurrency.nut.ts"],
+  "include": ["nut/**/*.ts", "unit/**/*.ts", "perf/**/*.ts"],
   "compilerOptions": {
     "noEmit": true,
     "skipLibCheck": true,

diff --git a/test/unit/config/configTest.ts → test/unit/config/config.test.ts b/test/unit/config/configTest.ts → test/unit/config/config.test.ts
diff --git a/test/unit/config/configAggregatorTest.ts → test/unit/config/configAggregator.test.ts b/test/unit/config/configAggregatorTest.ts → test/unit/config/configAggregator.test.ts
diff --git a/test/unit/config/configFileTest.ts → test/unit/config/configFile.test.ts b/test/unit/config/configFileTest.ts → test/unit/config/configFile.test.ts
diff --git a/test/unit/config/configStoreTest.ts → test/unit/config/configStore.test.ts b/test/unit/config/configStoreTest.ts → test/unit/config/configStore.test.ts
diff --git a/test/unit/config/envVarsTest.ts → test/unit/config/envVars.test.ts b/test/unit/config/envVarsTest.ts → test/unit/config/envVars.test.ts
diff --git a/test/unit/config/lwwMapTest.ts → test/unit/config/lwwMap.test.ts b/test/unit/config/lwwMapTest.ts → test/unit/config/lwwMap.test.ts
diff --git a/test/unit/config/ttlConfigTest.ts → test/unit/config/ttlConfig.test.ts b/test/unit/config/ttlConfigTest.ts → test/unit/config/ttlConfig.test.ts
@@ -51,7 +51,7 @@ describe('TTLConfig', () => {
     it('should return the latest entry', async () => {
       const config = await TestConfig.create();
       config.set('1', { one: 'one' });
-      await sleep(1000);
+      await sleep(200);
       config.set('2', { two: 'two' });
       const latest = config.getLatestEntry();
       expect(latest).to.deep.equal(['2', config.get('2')]);
@@ -68,7 +68,7 @@ describe('TTLConfig', () => {
     it('should return the key of the latest entry', async () => {
       const config = await TestConfig.create();
       config.set('1', { one: 'one' });
-      await sleep(1000);
+      await sleep(200);
       config.set('2', { two: 'two' });
       const latest = config.getLatestKey();
       expect(latest).to.equal('2');

diff --git a/test/unit/crypto/cryptoKeyFailuresTest.ts → test/unit/crypto/cryptoKeyFailures.test.ts b/test/unit/crypto/cryptoKeyFailuresTest.ts → test/unit/crypto/cryptoKeyFailures.test.ts
diff --git a/test/unit/crypto/cryptoTest.ts → test/unit/crypto/cryptoTest.test.ts b/test/unit/crypto/cryptoTest.ts → test/unit/crypto/cryptoTest.test.ts
diff --git a/test/unit/crypto/keyChainTest.ts → test/unit/crypto/keyChain.test.ts b/test/unit/crypto/keyChainTest.ts → test/unit/crypto/keyChain.test.ts
diff --git a/test/unit/crypto/keyChainImplTest.ts → test/unit/crypto/keyChainImpl.test.ts b/test/unit/crypto/keyChainImplTest.ts → test/unit/crypto/keyChainImpl.test.ts
diff --git a/test/unit/crypto/secureStringTest.ts → test/unit/crypto/secureString.test.ts b/test/unit/crypto/secureStringTest.ts → test/unit/crypto/secureString.test.ts
diff --git a/test/unit/deviceOauthServiceTest.ts → test/unit/deviceOauthService.test.ts b/test/unit/deviceOauthServiceTest.ts → test/unit/deviceOauthService.test.ts
diff --git a/test/unit/globalTest.ts → test/unit/global.test.ts b/test/unit/globalTest.ts → test/unit/global.test.ts
diff --git a/test/unit/lifecycleEventsTest.ts → test/unit/lifecycleEvents.test.ts b/test/unit/lifecycleEventsTest.ts → test/unit/lifecycleEvents.test.ts
diff --git a/test/unit/logger/cleanupTest.ts → test/unit/logger/cleanup.test.ts b/test/unit/logger/cleanupTest.ts → test/unit/logger/cleanup.test.ts
diff --git a/test/unit/logger/filterTest.ts → test/unit/logger/filter.test.ts b/test/unit/logger/filterTest.ts → test/unit/logger/filter.test.ts
diff --git a/test/unit/loggerTest.ts → test/unit/logger/logger.test.ts b/test/unit/loggerTest.ts → test/unit/logger/logger.test.ts
@@ -10,8 +10,8 @@
 
 import { expect, config as chaiConfig } from 'chai';
 import { isString } from '@salesforce/ts-types';
-import { Logger, LoggerLevel, computeLevel } from '../../src/logger/logger';
-import { shouldThrowSync, TestContext } from '../../src/testSetup';
+import { Logger, LoggerLevel, computeLevel } from '../../../src/logger/logger';
+import { shouldThrowSync, TestContext } from '../../../src/testSetup';
 
 // NOTE: These tests still use 'await' which is how it use to work and were left to make
 // sure we didn't regress the way they were used.

diff --git a/test/unit/messagesTest.ts → test/unit/messages.test.ts b/test/unit/messagesTest.ts → test/unit/messages.test.ts
diff --git a/test/unit/org/authInfoTest.ts → test/unit/org/authInfo.test.ts b/test/unit/org/authInfoTest.ts → test/unit/org/authInfo.test.ts
diff --git a/test/unit/org/authRemoverTest.ts → test/unit/org/authRemover.test.ts b/test/unit/org/authRemoverTest.ts → test/unit/org/authRemover.test.ts
diff --git a/test/unit/org/connectionTest.ts → test/unit/org/connection.test.ts b/test/unit/org/connectionTest.ts → test/unit/org/connection.test.ts
diff --git a/test/unit/org/orgTest.ts → test/unit/org/org.test.ts b/test/unit/org/orgTest.ts → test/unit/org/org.test.ts
diff --git a/test/unit/org/permissionSetAssignmentTest.ts → .../unit/org/permissionSetAssignment.test.ts b/test/unit/org/permissionSetAssignmentTest.ts → .../unit/org/permissionSetAssignment.test.ts
diff --git a/test/unit/org/scratchOrgCreateTest.ts → test/unit/org/scratchOrgCreate.test.ts b/test/unit/org/scratchOrgCreateTest.ts → test/unit/org/scratchOrgCreate.test.ts
diff --git a/test/unit/org/scratchOrgErrorCodesTest.ts → test/unit/org/scratchOrgErrorCodes.test.ts b/test/unit/org/scratchOrgErrorCodesTest.ts → test/unit/org/scratchOrgErrorCodes.test.ts
diff --git a/...t/org/scratchOrgFeatureDeprecationTest.ts → .../org/scratchOrgFeatureDeprecation.test.ts b/...t/org/scratchOrgFeatureDeprecationTest.ts → .../org/scratchOrgFeatureDeprecation.test.ts
diff --git a/test/unit/org/scratchOrgInfoApiTest.ts → test/unit/org/scratchOrgInfoApi.test.ts b/test/unit/org/scratchOrgInfoApiTest.ts → test/unit/org/scratchOrgInfoApi.test.ts
diff --git a/test/unit/org/scratchOrgInfoGeneratorTest.ts → .../unit/org/scratchOrgInfoGenerator.test.ts b/test/unit/org/scratchOrgInfoGeneratorTest.ts → .../unit/org/scratchOrgInfoGenerator.test.ts
diff --git a/...it/org/scratchOrgSettingsGeneratorTest.ts → ...t/org/scratchOrgSettingsGenerator.test.ts b/...it/org/scratchOrgSettingsGeneratorTest.ts → ...t/org/scratchOrgSettingsGenerator.test.ts
diff --git a/test/unit/org/userTest.ts → test/unit/org/user.test.ts b/test/unit/org/userTest.ts → test/unit/org/user.test.ts
diff --git a/test/unit/projectTest.ts → test/unit/project.test.ts b/test/unit/projectTest.ts → test/unit/project.test.ts
diff --git a/test/unit/schema/validatorTest.ts → test/unit/schema/validator.test.ts b/test/unit/schema/validatorTest.ts → test/unit/schema/validator.test.ts
diff --git a/test/unit/sfErrorTest.ts → test/unit/sfError.test.ts b/test/unit/sfErrorTest.ts → test/unit/sfError.test.ts
@@ -79,15 +79,15 @@ describe('SfError', () => {
     it('returned `name:message` when no cause', () => {
       const err = new SfError('test');
       expect(inspect(err)).to.include('SfError: test');
-      expect(inspect(err)).to.include('sfErrorTest.ts');
+      expect(inspect(err)).to.include('sfError.test.ts');
       // there's always 1 cause from the `cause:` property, even if undefined
       expect(inspect(err)?.match(causeRegex)).to.have.lengthOf(1);
     });
     it('1 cause', () => {
       const nestedError = new Error('nested');
       const err = new SfError('test', undefined, undefined, nestedError);
       expect(inspect(err)).to.include('SfError: test');
-      expect(inspect(err)).to.include('sfErrorTest.ts');
+      expect(inspect(err)).to.include('sfError.test.ts');
       expect(inspect(err)).to.include('nested');
       expect(inspect(err)?.match(causeRegex)).to.have.lengthOf(1);
       expect(inspect(err)?.match(nestedCauseRegex)).to.be.null;
@@ -97,7 +97,7 @@ describe('SfError', () => {
       const nestedError2 = new Error('nested2', { cause: nestedError });
       const err = new SfError('test', undefined, undefined, nestedError2);
       expect(inspect(err)).to.include('SfError: test');
-      expect(inspect(err)).to.include('sfErrorTest.ts');
+      expect(inspect(err)).to.include('sfError.test.ts');
       expect(inspect(err)).to.include('nested');
       expect(inspect(err)).to.include('nested2');
       expect(inspect(err)?.match(causeRegex)).to.have.lengthOf(1);

diff --git a/...Aggregator/accessors/aliasAccessorTest.ts → ...ggregator/accessors/aliasAccessor.test.ts b/...Aggregator/accessors/aliasAccessorTest.ts → ...ggregator/accessors/aliasAccessor.test.ts
diff --git a/...teAggregator/accessors/orgAccessorTest.ts → ...eAggregator/accessors/orgAccessor.test.ts b/...teAggregator/accessors/orgAccessorTest.ts → ...eAggregator/accessors/orgAccessor.test.ts
diff --git a/...gregator/accessors/sandboxAccessorTest.ts → ...regator/accessors/sandboxAccessor.test.ts b/...gregator/accessors/sandboxAccessorTest.ts → ...regator/accessors/sandboxAccessor.test.ts
diff --git a/test/unit/status/myDomainResolverTest.ts → test/unit/status/myDomainResolver.test.ts b/test/unit/status/myDomainResolverTest.ts → test/unit/status/myDomainResolver.test.ts
diff --git a/test/unit/status/pollingClientTest.ts → test/unit/status/pollingClient.test.ts b/test/unit/status/pollingClientTest.ts → test/unit/status/pollingClient.test.ts
diff --git a/test/unit/status/streamingClientTest.ts → test/unit/status/streamingClient.test.ts b/test/unit/status/streamingClientTest.ts → test/unit/status/streamingClient.test.ts
diff --git a/test/unit/testSetupTest.ts → test/unit/testSetup.test.ts b/test/unit/testSetupTest.ts → test/unit/testSetup.test.ts
diff --git a/test/unit/util/cacheTest.ts → test/unit/util/cache.test.ts b/test/unit/util/cacheTest.ts → test/unit/util/cache.test.ts
diff --git a/test/unit/util/directoryWriterTest.ts → test/unit/util/directoryWriter.test.ts b/test/unit/util/directoryWriterTest.ts → test/unit/util/directoryWriter.test.ts
diff --git a/test/unit/util/fileLockingTest.ts → test/unit/util/fileLocking.test.ts b/test/unit/util/fileLockingTest.ts → test/unit/util/fileLocking.test.ts
diff --git a/test/unit/util/findUppercaseKeysTest.ts → test/unit/util/findUppercaseKeys.test.ts b/test/unit/util/findUppercaseKeysTest.ts → test/unit/util/findUppercaseKeys.test.ts
diff --git a/test/unit/util/getJwtAudienceUrlTest.ts → test/unit/util/getJwtAudienceUrl.test.ts b/test/unit/util/getJwtAudienceUrlTest.ts → test/unit/util/getJwtAudienceUrl.test.ts
diff --git a/test/unit/util/internalTest.ts → test/unit/util/internal.test.ts b/test/unit/util/internalTest.ts → test/unit/util/internal.test.ts
diff --git a/test/unit/util/mapKeysTest.ts → test/unit/util/mapKeys.test.ts b/test/unit/util/mapKeysTest.ts → test/unit/util/mapKeys.test.ts
diff --git a/test/unit/util/sfdcTest.ts → test/unit/util/sfdc.test.ts b/test/unit/util/sfdcTest.ts → test/unit/util/sfdc.test.ts
diff --git a/test/unit/util/sfdcUrlTest.ts → test/unit/util/sfdcUrl.test.ts b/test/unit/util/sfdcUrlTest.ts → test/unit/util/sfdcUrl.test.ts
diff --git a/test/unit/util/unwrapArrayTest.ts → test/unit/util/unwrapArray.test.ts b/test/unit/util/unwrapArrayTest.ts → test/unit/util/unwrapArray.test.ts
diff --git a/test/unit/util/zipWriterTest.ts → test/unit/util/zipWriter.test.ts b/test/unit/util/zipWriterTest.ts → test/unit/util/zipWriter.test.ts
diff --git a/test/unit/webOauthServerTest.ts → test/unit/webOauthServer.test.ts b/test/unit/webOauthServerTest.ts → test/unit/webOauthServer.test.ts
Benchmark suite	Current: `4bf9406`	Previous: `00155a3`	Ratio
`Child logger creation`	`465906` ops/sec (`±1.38%`)	`455392` ops/sec (`±0.97%`)	`0.98`
`Logging a string on root logger`	`781598` ops/sec (`±8.00%`)	`791037` ops/sec (`±9.82%`)	`1.01`
`Logging an object on root logger`	`569457` ops/sec (`±10.56%`)	`591149` ops/sec (`±6.70%`)	`1.04`
`Logging an object with a message on root logger`	`6602` ops/sec (`±212.40%`)	`6496` ops/sec (`±209.46%`)	`0.98`
`Logging an object with a redacted prop on root logger`	`487604` ops/sec (`±6.71%`)	`467577` ops/sec (`±9.12%`)	`0.96`
`Logging a nested 3-level object on root logger`	`368897` ops/sec (`±6.98%`)	`340281` ops/sec (`±8.75%`)	`0.92`
Benchmark suite	Current: `4bf9406`	Previous: `00155a3`	Ratio
`Child logger creation`	`325705` ops/sec (`±1.05%`)	`328177` ops/sec (`±0.88%`)	`1.01`
`Logging a string on root logger`	`733623` ops/sec (`±4.72%`)	`750018` ops/sec (`±7.39%`)	`1.02`
`Logging an object on root logger`	`589539` ops/sec (`±5.91%`)	`605448` ops/sec (`±5.27%`)	`1.03`
`Logging an object with a message on root logger`	`6303` ops/sec (`±204.07%`)	`8073` ops/sec (`±200.70%`)	`1.28`
`Logging an object with a redacted prop on root logger`	`472344` ops/sec (`±8.66%`)	`424643` ops/sec (`±16.05%`)	`0.90`
`Logging a nested 3-level object on root logger`	`337048` ops/sec (`±4.39%`)	`329864` ops/sec (`±6.00%`)	`0.98`