Skip to content

Commit

Permalink
chore: polish workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
@mingxuanzhangsfdx
mingxuanzhangsfdx committed Feb 20, 2024
1 parent a8484c8 commit 33cac99
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/esbuild-publish.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,11 @@ jobs:
with:
node-version: ${{ inputs.nodeVersion }}
registry-url: 'https://registry.npmjs.org'
cache: yarn
- name: Install esbuild Dependencies
run: |
yarn add esbuild@^0.19.5 -D
yarn add esbuild-plugin-pino@^2.1.0 -D
yarn add npm-dts@^1.3.12 -D
yarn add esbuild-plugin-tsc@^0.4.0 -D
- name: Install All Dependencies
run: |
yarn install --network-timeout 600000
yarn add -D esbuild@^0.19.5 esbuild-plugin-pino@^2.1.0 npm-dts@^1.3.12 esbuild-plugin-tsc@^0.4.0
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
- name: Update for Bundling
run: |
node scripts/updateForBundling.js
Expand Down

4 comments on commit 33cac99

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 33cac99 Previous: a8484c8 Ratio
Child logger creation 491427 ops/sec (±0.51%) 469236 ops/sec (±1.34%) 0.95
Logging a string on root logger 837404 ops/sec (±9.79%) 772749 ops/sec (±8.53%) 0.92
Logging an object on root logger 649825 ops/sec (±9.85%) 593952 ops/sec (±6.73%) 0.91
Logging an object with a message on root logger 26352 ops/sec (±184.20%) 9418 ops/sec (±201.83%) 0.36
Logging an object with a redacted prop on root logger 515283 ops/sec (±7.36%) 388988 ops/sec (±13.63%) 0.75
Logging a nested 3-level object on root logger 24867 ops/sec (±183.63%) 353950 ops/sec (±8.47%) 14.23

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33cac99 Previous: a8484c8 Ratio
Logging a nested 3-level object on root logger 24867 ops/sec (±183.63%) 353950 ops/sec (±8.47%) 14.23

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 33cac99 Previous: a8484c8 Ratio
Child logger creation 331956 ops/sec (±1.67%) 307386 ops/sec (±0.90%) 0.93
Logging a string on root logger 781846 ops/sec (±9.08%) 627390 ops/sec (±9.49%) 0.80
Logging an object on root logger 605912 ops/sec (±6.94%) 516640 ops/sec (±7.64%) 0.85
Logging an object with a message on root logger 7638 ops/sec (±201.72%) 313807 ops/sec (±5.82%) 41.08
Logging an object with a redacted prop on root logger 405076 ops/sec (±12.76%) 4133 ops/sec (±220.21%) 0.010203023630133605
Logging a nested 3-level object on root logger 322975 ops/sec (±4.36%) 222262 ops/sec (±23.28%) 0.69

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33cac99 Previous: a8484c8 Ratio
Logging an object with a message on root logger 7638 ops/sec (±201.72%) 313807 ops/sec (±5.82%) 41.08

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.