Merge pull request #1146 from forcedotcom/mz/bundle-test-cover

Mz/bundle test cover
forcedotcom · Oct 3, 2024 · 1c92ea7 · 1c92ea7
2 parents c59a6d3 + 0575b4a
commit 1c92ea7
Show file tree

Hide file tree

Showing 15 changed files with 1,930 additions and 4,059 deletions.
diff --git a/.github/workflows/bundle.yml b/.github/workflows/bundle.yml
@@ -25,17 +25,12 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
       - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
-      - name: Install esbuild Dependencies
-        run: |
-          yarn add -D esbuild@^0.19.5 esbuild-plugin-pino@^2.1.0 npm-dts@^1.3.12 esbuild-plugin-tsc@^0.4.0
-      - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
       - name: Update for Bundling
         run: |
           node scripts/updateForBundling.js
-      - name: Generate Bundle
+      - name: Generate Bundle and Check if there is any dependency that needs to be externalized and is not in the whitelist.
         run: |
-          yarn build
-          node scripts/build.js
+          node scripts/bundleWithCheck.js
       - name: Post Bundling Update
         run: |
           node scripts/postBundlingUpdate.js
diff --git a/.github/workflows/esbuild-publish.yml b/.github/workflows/esbuild-publish.yml
@@ -40,10 +40,6 @@ jobs:
           registry-url: 'https://registry.npmjs.org'
           cache: yarn
       - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
-      - name: Install esbuild Dependencies
-        run: |
-          yarn add -D esbuild@^0.19.5 esbuild-plugin-pino@^2.1.0 npm-dts@^1.3.12 esbuild-plugin-tsc@^0.4.0
-      - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
       - name: Update for Bundling
         run: |
           node scripts/updateForBundling.js

diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml
@@ -19,6 +19,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
       - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
         with:
           ignore-scripts: true

diff --git a/.github/workflows/testExternalProjects.yml b/.github/workflows/testExternalProjects.yml
@@ -51,7 +51,6 @@ jobs:
       - name: Add dependencies to bundle node_modules
         run: |
           yarn install  --network-timeout 600000
-          yarn add -D esbuild@^0.19.5 esbuild-plugin-pino@^2.1.0 npm-dts@^1.3.12 esbuild-plugin-tsc@^0.4.0
         working-directory: node_modules/@salesforce/core
       - name: Update for bundling
         run: node scripts/updateForBundling.js

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -2,3 +2,4 @@
 . "$(dirname "$0")/_/husky.sh"
 
 yarn lint && yarn pretty-quick --staged
+node ./scripts/scanTs.js
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,3 +2,4 @@
		. "$(dirname "$0")/_/husky.sh"

		yarn lint && yarn pretty-quick --staged
		node ./scripts/scanTs.js