fix: updated various logic and QOL on User and PermissionSetAssignment

src/connection.ts

@@ -75,7 +75,7 @@ export class Connection extends JSForceConnection {
   // We want to use 1 logger for this class and the jsForce base classes so override
   // the jsForce connection.tooling.logger and connection.logger.
   private logger!: Logger;
-  private transport!: { httpRequest: (info: RequestInfo) => JsonMap };
+  private _transport!: { httpRequest: (info: RequestInfo) => JsonMap };
   private _normalizeUrl!: (url: string) => string;
   private options: Connection.Options;
 
@@ -158,7 +158,7 @@ export class Connection extends JSForceConnection {
 
     merge(headers, SFDX_HTTP_HEADERS, request.headers);
 
-    return this.transport.httpRequest({
+    return this._transport.httpRequest({
       method: request.method,
       url: request.url,
       headers,

src/exported.ts

@@ -73,6 +73,8 @@ export { MyDomainResolver } from './status/myDomainResolver';
 
 export { DefaultUserFields, REQUIRED_FIELDS, User, UserFields } from './user';
 
+export { PermissionSetAssignment, PermissionSetAssignmentFields } from './permissionSetAssignment';
+
 // Utility sub-modules
 export * from './util/fs';
 export * from './util/sfdc';

src/permissionSetAssignment.ts

@@ -101,7 +101,7 @@ export class PermissionSetAssignment {
       .sobject('PermissionSetAssignment')
       .create(mapKeys(assignment, (value: unknown, key: string) => upperFirst(key)));
 
-    if (hasArray(createResponse, 'errors')) {
+    if (hasArray(createResponse, 'errors') && createResponse.errors.length > 0) {
       const messages: Messages = Messages.loadMessages('@salesforce/core', 'permissionSetAssignment');
       let message = messages.getMessage('errorsEncounteredCreatingAssignment');
 

src/user.ts

@@ -29,7 +29,7 @@ import { SecureBuffer } from './secureBuffer';
 import { SfdxError } from './sfdxError';
 import { sfdc } from './util/sfdc';
 
-const PASSWORD_LENGTH = 10;
+const PASSWORD_LENGTH = 13;
 const LOWER = 'abcdefghijklmnopqrstuvwxyz';
 const UPPER = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
 const NUMBERS = '1234567890';
@@ -404,6 +404,7 @@ export class User extends AsyncCreatable<User.Options> {
     if (!fields) {
       throw SfdxError.create('@salesforce/core', 'user', 'missingFields');
     }
+    const conn: Connection = this.org.getConnection();
 
     const body = JSON.stringify({
       username: fields.username,
@@ -421,7 +422,7 @@ export class User extends AsyncCreatable<User.Options> {
 
     this.logger.debug(`user create request body: ${body}`);
 
-    const scimUrl = this.org.getConnection().normalizeUrl(scimEndpoint);
+    const scimUrl = conn.normalizeUrl(scimEndpoint);
     this.logger.debug(`scimUrl: ${scimUrl}`);
 
     const info: RequestInfo = {
@@ -431,7 +432,7 @@ export class User extends AsyncCreatable<User.Options> {
       body,
     };
 
-    const response = await this.org.getConnection().requestRaw(info);
+    const response = await conn.requestRaw(info);
     const responseBody = parseJsonMap(ensureString(response['body']));
     const statusCode = asNumber(response.statusCode);
 

test/unit/permissionSetAssignmentTest.ts

@@ -196,7 +196,7 @@ describe('permission set assignment tests', () => {
       try {
         await shouldThrow(assignment.create('123456', `${NS}__${PERM_SET_NAME}`));
       } catch (e) {
-        expect(e).to.have.property('name', 'notSuccessfulButNoErrorsReported');
+        expect(e).to.have.property('name', 'UnexpectedResult');
       }
     });
   });

test/unit/userTest.ts

@@ -112,7 +112,7 @@ describe('User Tests', () => {
     it('Should generate a password', () => {
       const password: SecureBuffer<void> = User.generatePasswordUtf8();
       password.value((buffer: Buffer): void => {
-        expect(buffer.toString('utf8').length).to.be.equal(6);
+        expect(buffer.toString('utf8').length).to.be.equal(9);
       });
     });
   });