-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary / base64 field automatic encoding and eager loading #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
changed the title
Binary fields
Binary / base64 field automatic encoding and eager loading
Sep 8, 2022
colincasey
reviewed
Sep 12, 2022
joshwlewis
force-pushed
the
binary-fields
branch
from
September 27, 2022 15:14
c1b1dd9
to
6076afd
Compare
colincasey
approved these changes
Sep 28, 2022
joshwlewis
force-pushed
the
binary-fields
branch
from
September 28, 2022 17:45
11f4ecd
to
a6a113d
Compare
This was referenced Sep 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic support for base64 / binary content, and is supported by the changes to type signatures in forcedotcom/sf-fx-sdk-nodejs#141.
The additional functionality has two parts:
binaryFields
property by eager-loading binary content during queries.binaryFields
when performing upstream record modification.An example function leveraging this new functionality might look like this:
GUS-W-11543492