fix: junit testresult file generation #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: fix junit testresult file generation Resolved an issue where the junit file generation created invalid XML files, because the failure message contains characters that should be XML-escaped. These are: <, >, &, " and '. Made sure to xml-encode these in the message, updated a testcase to make sure that this is now covered in a test as well.
* fix: fix junit testresult file generation Additional commit to also escape the method name, it can be '<compile>' when testcases fail because of compilation errors. The '<' and '>' characters also need to be escaped in that case.
klewis-sfdc
pushed a commit
that referenced
this pull request
Oct 24, 2022
Resolved an issue where the junit file generation created invalid XML files, because the failure message contains characters that should be XML-escaped. These are: <, >, &, " and '. Made sure to xml-encode these in the message, updated a testcase to make sure that this is now covered in a test as well. Additional commit to also escape the method name, it can be '<compile>' when testcases fail because of compilation errors. The '<' and '>' characters also need to be escaped in that case. Co-authored-by: Johannes Verelst <[email protected]>
WillieRuemmele
pushed a commit
that referenced
this pull request
Jan 31, 2023
Resolved an issue where the junit file generation created invalid XML files, because the failure message contains characters that should be XML-escaped. These are: <, >, &, " and '. Made sure to xml-encode these in the message, updated a testcase to make sure that this is now covered in a test as well. Additional commit to also escape the method name, it can be '<compile>' when testcases fail because of compilation errors. The '<' and '>' characters also need to be escaped in that case. Co-authored-by: Johannes Verelst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolved an issue where the junit file generation created invalid XML files, because the failure message
contains characters that should be XML-escaped. These are: <, >, &, " and '.
Made sure to xml-encode these in the message, updated a test case to make sure that this is now covered in
a test as well.
What issues does this PR fix or reference?
This PR fixes the following issue: #280
forcedotcom/cli#1183
Functionality Before
The junit generated created invalid XML, because XML characters like the quote were not properly escaped.
Functionality After
Valid XML generation