publish as a npm package #19
Conversation
| @@ -48,11 +43,10 @@ | |||
| }, | |||
| "repository": "https://github.com/developerforce/lwc-builder-ui", | |||
| "scripts": { | |||
| "build": "lwc-services build -m production", | |||
| "build": "lwc-services build", | |||
There was a problem hiding this comment.
why did you change this ??
There was a problem hiding this comment.
It strips all comments from LWC html files.
On lwc-builder-vscode side, it replaces <!-- CSP --> comment with vscode CSP from ui HTML file src/index.html
There was a problem hiding this comment.
So build cannot not be production mode. Without production flag, it doesn't strip comments.
Yes, this is not a good solution, so we will have to find out.
| @@ -29,11 +29,6 @@ | |||
| "npm": ">=6.4.1" | |||
| }, | |||
| "homepage": "https://github.com/developerforce/lwc-builder-ui", | |||
| "husky": { | |||
There was a problem hiding this comment.
why did you remove the hook?
There was a problem hiding this comment.
never mind, I just saw your comment
There was a problem hiding this comment.
but they say the issue is fixed now??
There was a problem hiding this comment.
This way of notation in package.json for husky is for husky@v4.
After v5, husky settings are moved to .husky folder at the top level.
Published this ui package as a npm package so that it can be installed on the builder vscode package through npm command.
Removed husky install due to npm publishing limitation. This issue is discussed below.
swagger-api/swagger-js#1911