Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When executing force:project:create, .eslintignore doesn't contain "*.app" #1004

Closed
zaki-yama opened this issue May 5, 2021 · 5 comments
Closed
Labels
bug Issue or pull request that identifies or fixes a bug investigating We're actively investigating this issue

Comments

@zaki-yama
Copy link

Summary

When I create a project by sfdx force:project:create, the generated .eslintignore doesn't contain *.app which represents Lightning(Aura) Application.

Steps To Reproduce:

Repository to reproduce: https://github.com/zaki-yama-labs/standard-sfdx-project

  1. Create a project by sfdx force:project:create --projectname=standard-sfdx-project
  2. cd standard-sfdx-project
  3. Open .eslintignore

Expected result

I think .eslintignore should contain **/aura/**/*.app same as other aura-related resources.

Actual result

It doesn't contain **/aura/**/*.app.

Additional information

The problem is, if there are Lightning Application files (*.app) locally, then run npm run lint:aura, it raises an error.

$ npm run lint:aura

> [email protected] lint:aura /Users/yamazaki/repos/github.com/zaki-yama-labs/standard-sfdx-project
> eslint **/aura/**


/Users/yamazaki/repos/github.com/zaki-yama-labs/standard-sfdx-project/force-app/main/default/aura/TestApp/TestApp.app
  1:1  error  Parsing error: Unexpected token <

✖ 1 problem (1 error, 0 warnings)

SFDX CLI Version(to find the version of the CLI engine run sfdx --version):

$ sfdx --version
sfdx-cli/7.94.3-a4e7c7955b darwin-x64 node-v14.15.4

SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)

$ sfdx plugins --core
@oclif/plugin-autocomplete 0.3.0 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.10.0 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/lwc-dev-server 2.10.0
├─ @oclif/plugin-help 2.2.3
└─ @oclif/plugin-update 1.3.10
@salesforce/sfdx-trust 3.6.0 (core)
alias 1.1.8 (core)
auth 1.5.1 (core)
config 1.2.7 (core)
generator 1.1.5 (core)
salesforcedx 51.6.0 (core)
├─ data 0.4.3 (core)
├─ limits 1.0.4 (core)
├─ schema 1.0.4 (core)
├─ apex 0.1.4 (core)
├─ templates 51.3.0 (core)
├─ org 1.6.0 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
├─ custom-metadata 1.0.11 (core)
├─ salesforce-alm 51.6.6 (core)
└─ user 1.2.1 (core)
sfdx-cli 7.94.3 (core)
telemetry 1.1.1 (core)

OS and version:
macOS Big Sur 11.3

@zaki-yama zaki-yama added the investigating We're actively investigating this issue label May 5, 2021
@zaki-yama zaki-yama changed the title When executing force:project:create, .eslintignore doesn't contain "*.app" When executing force:project:create, .eslintignore doesn't contain "*.app" May 5, 2021
@github-actions
Copy link

github-actions bot commented May 5, 2021

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

@WillieRuemmele WillieRuemmele added the bug Issue or pull request that identifies or fixes a bug label May 5, 2021
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-9229019

@github-actions
Copy link

github-actions bot commented May 5, 2021

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

@WillieRuemmele
Copy link
Member

Hi @zaki-yama this was merged and will be released soon. Thanks for pointing that out 👍

@zaki-yama
Copy link
Author

@WillieRuemmele
Thank you for the quick fix!

jshackell-sfdc added a commit that referenced this issue May 13, 2021
mshanemc pushed a commit that referenced this issue May 13, 2021
* 51.12 RNs

* Add fix to github issue #1004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue or pull request that identifies or fixes a bug investigating We're actively investigating this issue
Projects
None yet
Development

No branches or pull requests

3 participants