@W-14003910: readiness: warn on literal null filter value if operator is not Equals nor NotEquals

packages/analyticsdx-template-lint/src/schemas/readiness-schema.json

@@ -367,6 +367,20 @@
             "description": "The value to compare against. This can use ${...} expressions."
           }
         },
+        "if": {
+          "properties": {
+            "operator": { "enum": ["LessThan", "LessThanEqual", "GreaterThan", "GreaterThanEqual", "In", "NotIn"] }
+          },
+          "required": ["operator"]
+        },
+        "then": {
+          "properties": {
+            "value": {
+              "type": ["string", "number", "boolean", "array"],
+              "description": "The value to compare against. This can use ${...} expressions."
+            }
+          }
+        },
         "required": ["field", "operator", "value"],
         "defaultSnippets": [
           {

packages/analyticsdx-template-lint/test/unit/schemas/invalidReadinessJsonTests.ts

@@ -42,4 +42,20 @@ describe('readiness-schema.json finds errors in', () => {
       'definition.datacloud.object'
     );
   });
+
+  it('invalid-values.json', async () => {
+    const errors = await validate('invalid-values.json');
+    errors.expectInvalidProps(
+      false,
+      'templateRequirements[0].type',
+      'definition.empty.type',
+      'definition.bad.type',
+      'definition.filterOp.filters[0].value',
+      'definition.filterOp.filters[1].value',
+      'definition.filterOp.filters[2].value',
+      'definition.filterOp.filters[3].value',
+      'definition.filterOp.filters[4].value',
+      'definition.filterOp.filters[5].value'
+    );
+  });
 });

packages/analyticsdx-template-lint/test/unit/schemas/testfiles/readiness/invalid/invalid-values.json

@@ -0,0 +1,52 @@
+{
+  "templateRequirements": [
+    {
+      "expression": "${true}",
+      "type": "error"
+    }
+  ],
+  "definition": {
+    "empty": {
+      "type": ""
+    },
+    "bad": {
+      "type": "error"
+    },
+    "filterOp": {
+      "type": "SobjectRowCount",
+      "sobject": "foo",
+      "filters": [
+        {
+          "field": "field",
+          "operator": "GreaterThan",
+          "value": null
+        },
+        {
+          "field": "field",
+          "operator": "GreaterThanEqual",
+          "value": null
+        },
+        {
+          "field": "field",
+          "operator": "LessThan",
+          "value": null
+        },
+        {
+          "field": "field",
+          "operator": "LessThanEqual",
+          "value": null
+        },
+        {
+          "field": "field",
+          "operator": "NotIn",
+          "value": null
+        },
+        {
+          "field": "field",
+          "operator": "In",
+          "value": null
+        }
+      ]
+    }
+  }
+}

packages/analyticsdx-template-lint/test/unit/schemas/testfiles/readiness/valid/nulls.json

@@ -17,6 +17,17 @@
       "type": "SobjectRowCount",
       "sobject": "Account",
       "filters": null
+    },
+    "filterOp": {
+      "type": "SobjectRowCount",
+      "sobject": "foo",
+      "filters": [
+        {
+          "field": "field",
+          "operator": "Equal",
+          "value": null
+        }
+      ]
     }
   }
 }