-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
@W-14003910: readiness: warn on literal null filter value if operator…
… is not Equals nor NotEquals (#162) * show warning if using null values for unexpected filter operator * add unit test * fix for a regression * remove not needed if check * add expected valid null check
- Loading branch information
1 parent
883a7b7
commit adec218
Showing
4 changed files
with
93 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...alyticsdx-template-lint/test/unit/schemas/testfiles/readiness/invalid/invalid-values.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"templateRequirements": [ | ||
{ | ||
"expression": "${true}", | ||
"type": "error" | ||
} | ||
], | ||
"definition": { | ||
"empty": { | ||
"type": "" | ||
}, | ||
"bad": { | ||
"type": "error" | ||
}, | ||
"filterOp": { | ||
"type": "SobjectRowCount", | ||
"sobject": "foo", | ||
"filters": [ | ||
{ | ||
"field": "field", | ||
"operator": "GreaterThan", | ||
"value": null | ||
}, | ||
{ | ||
"field": "field", | ||
"operator": "GreaterThanEqual", | ||
"value": null | ||
}, | ||
{ | ||
"field": "field", | ||
"operator": "LessThan", | ||
"value": null | ||
}, | ||
{ | ||
"field": "field", | ||
"operator": "LessThanEqual", | ||
"value": null | ||
}, | ||
{ | ||
"field": "field", | ||
"operator": "NotIn", | ||
"value": null | ||
}, | ||
{ | ||
"field": "field", | ||
"operator": "In", | ||
"value": null | ||
} | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters