fix: Switch to transform streams for csv-writer to avoid crash when writing huge CSVs #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! |
hknokh
added a commit
that referenced
this pull request
Jul 31, 2023
|
Hello, |
R0Wi
pushed a commit
to R0Wi/SFDX-Data-Move-Utility
that referenced
this pull request
Aug 1, 2023
* Stream behaviour was introduced with forcedotcom#617 * We have been waiting for the csvTransformStream only * FileStream was not fully flushed so we missed CSV records forcedotcom#618
R0Wi
added a commit
to R0Wi/SFDX-Data-Move-Utility
that referenced
this pull request
Aug 1, 2023
* Stream behaviour was introduced with forcedotcom#617 * We have been waiting for the csvTransformStream only * FileStream was not fully flushed so we missed CSV records forcedotcom#618
R0Wi
added a commit
to R0Wi/SFDX-Data-Move-Utility
that referenced
this pull request
Aug 2, 2023
* Stream behaviour was introduced with forcedotcom#617 * We have been waiting for the csvTransformStream only * FileStream was not fully flushed so we missed CSV records forcedotcom#618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a CSV that is too large (GBs) the app crashes with a
RangeError: Invalid string length.From
csv-writer's documentation:However, if you need to keep writing large data to a certain file, you would want to create node's transform stream and use CsvStringifier, which is explained later, inside it , and pipe the stream into a file write stream.
This PR switches to a transform stream to fix the issue. Tested with a 1 GB+ CSV MissingParentRecordsReport.csv, and it seems to work fine.