Decent pull request #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed color of copyright links to something more decent.
Street Fighter 2, mugshots. Defeated Screen
Contributor added to 'sf2' game in generator.js
*Added super Mario Bros ending screen *Changed contributor's text *Updated README.md
# Conflicts: # README.md
|
Your redirect from the base URL to a URL with an anchor for one of the generators breaks the back button on my browser. |
|
I might have time later today to check this out |
|
Well the branch went stale. You might get more of a response if this was split into a few specialized branches. Then again, maybe foone is too busy tweeting to look at any of this. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey foone! Not sure if you saw my previous pull request , this one is a little more considerable to your files and has proper commits. Also No conflicts!
In the contributors there's a "contributors" link from github, I thought it was appropriate.
You can check working version here:
https://iokaravas.github.io/SierraDeathGenerator
Hope you like it. We need the new logos though ;)