Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC errors #180

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix MSVC errors #180

merged 2 commits into from
Nov 15, 2023

Conversation

shohirose
Copy link
Contributor

I made several changes to your library. I hope these changes improve your code.

The reasons of the 2nd commit about /utf-8 and /EHsc are

  • Because compiling lexy with MSVC requires utf-8, it is natural to add /utf-8 option to lexy_dev itself.
  • When opening the root directory with Visual Studio, VS does not automatically add /EHsc option, leading to a compilation error. (This does not occur when using VSCode.)

.gitignore Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
tests/lexy/detail/string_view.cpp Show resolved Hide resolved
@foonathan foonathan merged commit 8b39b2f into foonathan:main Nov 15, 2023
11 checks passed
@foonathan
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants