-
Notifications
You must be signed in to change notification settings - Fork 9
Bump selenium-webdriver from 3.6.0 to 4.0.0 #1563
Bump selenium-webdriver from 3.6.0 to 4.0.0 #1563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK Selenium v4 isn't compatible with older browsers. This will need some development work done first if it is, and some research to determine if it isn't.
f9b58a5
to
8bc0bec
Compare
8bc0bec
to
15615c5
Compare
@queengooborg how old browsers does Selenium v4 still work with? |
It looks like that older browser compatibility thing might've been an alpha limitation. Using BrowserStack's capabilities configurator, I'm able to select basically every browser. So, I think we're good to go on upgrading this, however we might need to make some adjustments to the Selenium script. |
Tests are passing, but I guess that just means there's no real testing of the Selenium code in CI. |
Right, there isn't really any way we can automate testing of the Selenium script, particularly due to the fact that Selenium is designed to be the testing framework itself. Edit: actually technically we could auto-test the Selenium script, but that involves figuring out #1308 first. |
Indeed, if we can run Selenium on release, then we could also do a smoke test for each PR, perhaps running a handful of tests for a specific version of some browser, expecting some exact results. |
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](SeleniumHQ/selenium@selenium-3.6.0...selenium-4.0.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
15615c5
to
60d6f22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates for Selenium v4 were much easier than I was expecting -- this is all ready to go now!
Bumps selenium-webdriver from 3.6.0 to 4.0.0.
Release notes
Sourced from selenium-webdriver's releases.
... (truncated)
Commits
3a21814
[js] bump JS to 4.0.03782f97
[js] Fixes cdp for Chrome and Firefox (#9909)614a408
[py] Bump python to 4.0.0b97b406
[dotnet] Fix typo committed by mistakeee723da
Bump to latest edge release77e99f6
Add atoJson
method toBrowser
so it becomes easier to use in Capabilitiesfcab887
[build] Add cdp 95 to python and JS87e3833
[python] Remove Edge legacy options. (#9908)81cf027
[dotnet] Update CHANGELOG with last changese41fc34
[dotnet] Fix CDP error getting body of redirect responsesMaintainer changes
This version was pushed to npm by sriharsha, a new releaser for selenium-webdriver since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)