Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the syntax error from my pull request earlier #46

Merged
merged 8 commits into from
Jun 4, 2017
Merged

Fixed the syntax error from my pull request earlier #46

merged 8 commits into from
Jun 4, 2017

Conversation

thorko
Copy link
Contributor

@thorko thorko commented Jun 1, 2017

Hi mirceaulinic,
sorry for my syntax issue. If fixed it.
Cheers
thorko

@mirceaulinic
Copy link
Collaborator

mirceaulinic commented Jun 2, 2017 •
edited
Loading

Hi @thorko thanks for this PR.
The tests are currently failing, due to file misconfigured filenames, e.g. test/mock/CLI_Configuration_commit_replace_confirmed_60Configuarion_CLI_.xml should be test/mock/CLI_Configuration_commit_replace_confirmed_60Configuration_CLI_.xml etc.

Also, please amend you commits to make sure they are linked to your GitHub profile (i.e. update your git settings to use the same email address) :-)

@mirceaulinic mirceaulinic added this to the 0.50 milestone Jun 2, 2017
@coveralls
Copy link

coveralls commented Jun 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 87.719% when pulling cde3a96 on DENICeG:master into 4153f13 on fooelisa:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.719% when pulling cde3a96 on DENICeG:master into 4153f13 on fooelisa:master.

@mirceaulinic mirceaulinic merged commit 80c9c8d into fooelisa:master Jun 4, 2017
@mirceaulinic mirceaulinic mentioned this pull request Jul 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.
3 participants
@thorko @mirceaulinic @coveralls