Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add delay in between multiple audits #79

Merged
merged 20 commits into from
Jan 28, 2023

Conversation

adamhenson
Copy link
Collaborator

@adamhenson adamhenson commented Jan 28, 2023

Summary

Determine issue if possible and fix foo-software/lighthouse-check-action#109

Please see the above issue for reasoning behind this change.

Copy link
Collaborator

@foo-lighthouse-bot foo-lighthouse-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device Report URL
mobile report https://www.foo.software

Device Report URL
desktop report https://www.foo.software

Copy link
Collaborator

@foo-lighthouse-bot foo-lighthouse-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://www.foo.software

Device URL
mobile https://www.foo.software

Device URL
desktop https://www.automated-lighthouse-check.com/

Device URL
mobile https://www.automated-lighthouse-check.com/

Not what you expected? Are your scores flaky? Try running on Foo instead

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 29.05% // Head: 29.08% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e93e815) compared to base (c571160).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   29.05%   29.08%   +0.02%     
==========================================
  Files          18       19       +1     
  Lines         468      471       +3     
  Branches      185      185              
==========================================
+ Hits          136      137       +1     
- Misses        254      256       +2     
  Partials       78       78              
Impacted Files Coverage Δ
src/localLighthouse.js 27.38% <0.00%> (-0.33%) ⬇️
src/helpers/utils.js 50.00% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamhenson adamhenson merged commit c29ba0a into master Jan 28, 2023
@adamhenson adamhenson deleted the fix/flaky-lighthouse-issue branch January 28, 2023 21:44
@adamhenson adamhenson changed the title fix: flaky Lighthouse reproduced in GitHub Action environment fix: add delay in between multiple audits Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocolTimeout occurs intermittently since upgrading from v8.0.0 to v9.1.0
3 participants