Skip to content

Commit

Permalink
Fix errors when testing Zain family
Browse files Browse the repository at this point in the history
* remote_styles: use correct font object
* googlefonts/axes_match: only run if font is variable

(PR # #4863)
  • Loading branch information
m4rc1e authored Oct 16, 2024
1 parent 919991b commit 1a24828
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
Below are the noteworthy changes from each release.
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).

## Upcoming release: 0.13.0a2 (2024-Oct-11)
## Upcoming release: 0.13.0a2 (2024-Oct-16)
### Noteworthy code-changes
- **[FontBakeryCondition:remote_styles]:** Fetching static fonts no longer raises an error. (PR # #4863)

### Migration of checks
#### Moved from OpenType to Universal profile
- **[name/no_copyright_on_description]**: Adding copyright information to the description name entry is bad practice but is not a breach of specification. (issue #4857)
Expand All @@ -13,6 +16,7 @@ A more detailed list of changes is available in the corresponding milestones for

#### On the Google Fonts profile
- **[googlefonts/article/images]:** Missing image files are now reported at **FATAL** level. (issue #4848)
- **[googlefonts/axes_match]:** Only run on variable fonts. This stops fontbakery producing an error on static fonts. (PR # #4863)

### Deprecated checks
#### Removed from the Universal profile
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def remote_styles(font):
)
rstyles[inst_subfamily] = remote_font
else:
rstyles[font["name"].getBestSubFamilyName()] = remote_font
rstyles[remote_font["name"].getBestSubFamilyName()] = remote_font
return rstyles


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

@check(
id="googlefonts/axes_match",
conditions=["remote_style"],
conditions=["is_variable_font", "remote_style"],
rationale="""
An updated font family must include the same axes found in the Google "
Fonts version, with the same axis ranges.
Expand Down

0 comments on commit 1a24828

Please sign in to comment.