📜 Logging tweaks and fixes #498
Conversation
* Prevent frontend from crashing with unknown log levels (eg ProgressLogging.@-progress) * Avoid spamming the user with infinite log relay errors once the remote log channel is closed * Only relay info-and-above-level logs from third party modules, to prevent excessive debug level log spam.
|
Thanks! I rushed this feature a little 😬 About relaying Debug level messages: the browser console actually has a log level filter built in! Everything enabled:
Debug disabled (button on top of the console):
We'll have to think about how all of this should be documented, but maybe we can leave in the Debug logs and ask users to filter there? On the other hand, the use case here is to enable logging for setups like github codespaces, binder, SSH, etc, and maybe Debug is only useful for package development, which you wouldn't do on those setups? |
|
Oh I just saw that you relay Debug from inside the notebook, that's smart |
by removing the line highlight and just doing cell highlight instead
| @@ -6,26 +6,16 @@ const log_functions = { | |||
| } | |||
|
|
|||
| export const handle_log = ({ level, msg, file, line, kwargs }, filename) => { | |||
| const f = log_functions[level] | |||
| const f = log_functions[level] || console.log | |||
There was a problem hiding this comment.
BTW, we could try to infer more closely whether it should be one of debug, info, warn and error should be used for nonstandard log levels (on the Julia side). But I figured that that console log isn't the UI we want anyway, so just having a crude fallback to bare console.log would be simple for now (and prevent the frontend from crashing)
I'm not quite sure what you mean by relay? All I've done is try to infer what the user cares about: they care about debugging their own notebook code, but not debugging some library which they happen to be |
|
Thanks! While I have you here, would you like to call today? |
|
Ah I missed that, sorry :) |
(eg ProgressLogging.@-progress)
log channel is closed
prevent excessive debug level log spam.
Fixes a few problems I found while testing #496